WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#5997 closed defect (bug) (fixed)

Grey line through Widget control div

Reported by: technosailor Owned by: mdawaffe
Milestone: 2.5 Priority: high
Severity: normal Version: 2.5
Component: General Keywords: has-patch needs-testing
Focuses: Cc:

Description

When a widget control box is open, the grey horizontal separator lines leak through into the div. Being that it is such a light grey, it's hard to tell that it's a line and not a scratch on the monitor. Screenshot attached for Safari 3/OSX

Attachments (2)

Picture 1.png (32.0 KB) - added by technosailor 7 years ago.
5997.diff (4.1 KB) - added by mdawaffe 7 years ago.

Download all attachments as: .zip

Change History (8)

@technosailor7 years ago

comment:1 @ryan7 years ago

  • Owner changed from anonymous to mdawaffe

comment:2 @mdawaffe7 years ago

  • Milestone changed from 2.6 to 2.5
  • Priority changed from normal to high

comment:3 @mdawaffe7 years ago

  • Status changed from new to assigned
  • Version set to 2.5

So this was fairly simply fixed in Safari by tweaking some positioning.

It turns out things are pretty broken in IE, though.

Attached works in FF2, Safari3, IE7 (FF3, IE6 untested).

  1. Tweak some positioning.
  2. Bug fix for JS URL "unserialize" function.
  3. Some trivial validation fixes.
  4. If IE, don't animate widget open/close. Just do it. The animations seem to be breaking badly because of some positioning/floating.

If someone else can tweak the CSS and/or JS to make the animation work in FF, Safari and IE, please go ahead.

@mdawaffe7 years ago

comment:4 @mdawaffe7 years ago

  • Keywords has-patch needs-testing added

comment:5 @ryan7 years ago

Works for me in FF2 and Safari3.

comment:6 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7086]) Widget admin layout fixes from mdawaffe. fixes #5997

Note: See TracTickets for help on using tickets.