WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 20 months ago

Last modified 20 months ago

#59980 closed task (blessed) (fixed)

PHPunit tests for wp_timezone_override_offset

Reported by: pbearne Owned by: johnbillion
Priority: normal Milestone: 6.8
Component: Date/Time Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses: tests

Description


Change History (11)

This ticket was mentioned in ​PR #5715 on ​WordPress/wordpress-develop by ​@pbearne.
3 years ago #1

  • Keywords has-patch has-unit-tests added

#2 @desrosj
2 years ago

  • Component Build/Test Tools → Date/Time
  • Milestone Awaiting Review → Future Release
  • Type defect (bug) → enhancement

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

#3 @pbearne
22 months ago

  • Milestone Future Release → 6.8
  • Owner set to pbearne
  • Status new → assigned

​@audrasjb commented on ​PR #5715:
21 months ago #4

I added a commit to this changeset to fix some WPCS issues.

#5 @desrosj
20 months ago

  • Focuses tests added

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
20 months ago

#7 @johnbillion
20 months ago

  • Owner changed from pbearne to johnbillion
  • Status assigned → reviewing

#8 @johnbillion
20 months ago

  • Type enhancement → task (blessed)

#9 @johnbillion
20 months ago

  • Resolution → fixed
  • Status reviewing → closed

In 59931:

Date/Time: Add tests that cover the wp_timezone_override_offset() function.

Props pbearne, audrasjb

Fixes #59980

#10 @SergeyBiryukov
20 months ago

In 59936:

Tests: Improve wp_timezone_override_offset() unit tests.

Includes:

  • Using a data provider to reduce code repetition.
  • Correcting the group annotation.

Follow-up to [59931].

See #59980.

#11 @audrasjb
20 months ago

FYI: this introduced a PHPUnit test failure with US daylight saving time: #63079.

Note: See TracTickets for help on using tickets.