WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 9 months ago

Last modified 9 months ago

#59980 closed task (blessed) (fixed)

PHPunit tests for wp_timezone_override_offset

Reported by: pbearne's profile pbearne Owned by: johnbillion's profile johnbillion
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Date/Time Keywords: has-patch has-unit-tests
Focuses: tests Cc:

Description


Change History (11)

This ticket was mentioned in ​PR #5715 on ​WordPress/wordpress-develop by ​@pbearne.
2 years ago #1

  • Keywords has-patch has-unit-tests added

#2 @desrosj
14 months ago

  • Component changed from Build/Test Tools to Date/Time
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

#3 @pbearne
12 months ago

  • Milestone changed from Future Release to 6.8
  • Owner set to pbearne
  • Status changed from new to assigned

​@audrasjb commented on ​PR #5715:
10 months ago #4

I added a commit to this changeset to fix some WPCS issues.

#5 @desrosj
10 months ago

  • Focuses tests added

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
10 months ago

#7 @johnbillion
9 months ago

  • Owner changed from pbearne to johnbillion
  • Status changed from assigned to reviewing

#8 @johnbillion
9 months ago

  • Type changed from enhancement to task (blessed)

#9 @johnbillion
9 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 59931:

Date/Time: Add tests that cover the wp_timezone_override_offset() function.

Props pbearne, audrasjb

Fixes #59980

#10 @SergeyBiryukov
9 months ago

In 59936:

Tests: Improve wp_timezone_override_offset() unit tests.

Includes:

  • Using a data provider to reduce code repetition.
  • Correcting the group annotation.

Follow-up to [59931].

See #59980.

#11 @audrasjb
9 months ago

FYI: this introduced a PHPUnit test failure with US daylight saving time: #63079.

Note: See TracTickets for help on using tickets.