Make WordPress Core

Opened 5 months ago

Last modified 4 weeks ago

#59996 new defect (bug)

Twenty Twenty: Calendar block does not apply font size from block option

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.1
Component: Bundled Theme Keywords: has-patch has-testing-info has-screenshots
Focuses: Cc:

Description

Steps to reproduce the issue.

  1. Activate Twenty Twenty theme.
  2. Choose Calendar block.
  3. Change the font size.

Now check the both the side editor and frontend.
You can able to see that whatever the font size you have choosen that is applied n editor side but there is no difference in font size in the front side.

I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/FJGNHTjxP6KzXkJ12bfx

Attachments (4)

59996.patch (726 bytes) - added by nidhidhandhukiya 5 months ago.
Calendar-block-before-patch.png (45.3 KB) - added by sabernhardt 4 months ago.
before the patch, the font size for any Calendar block is 1.8rem at a screen width larger than 700 pixels
Calendar-block-with-59996.patch.png (62.5 KB) - added by sabernhardt 4 months ago.
with the patch, the default font size increases to 2.1rem while custom sizes are supported
59996.2.patch (864 bytes) - added by shailu25 4 weeks ago.
Patch Updated

Download all attachments as: .zip

Change History (12)

#1 @yuvrajsinh2211
4 months ago

Testing of: https://core.trac.wordpress.org/attachment/ticket/59996/59996.patch

Tested in the below environment:

PHP: 8.1.9
WordPress: 6.4
Theme: Twenty Twenty
Browser: Chrome
Plugin: No plugins


Before Patch Screenshot:

Backend: https://prnt.sc/4WqBl0Q9wpid
Frontend: https://prnt.sc/QQCKgIgFh01k


After-Patch Screenshot:

Backend: https://prnt.sc/pw4lvLtWm1xY
Frontend: https://prnt.sc/c9noJG3wvc0m

After the patch, you can see the difference in font size on the front side.

As tested, Patch is working properly.

Last edited 4 months ago by yuvrajsinh2211 (previous) (diff)

This ticket was mentioned in Slack in #core-test by ankit-k-gupta. View the logs.


4 months ago

#3 @Ankit K Gupta
4 months ago

  • Keywords has-patch has-testing-info has-screenshots needs-testing added

#4 @anveshika
4 months ago

Patch Used - https://core.trac.wordpress.org/attachment/ticket/59996/59996.patch

Environment-

OS: Windows 10
Web Server: Apache/2.4.57 (Ubuntu) mod_fcgid/2.3.9 OpenSSL/1.1.1f
PHP: 8.0.29
WordPress: 6.4.2
Browser: Google Chrome
Theme: Twenty-Twenty

Before Patch- https://prnt.sc/JlsSXCfeT3sP
After Patch- https://prnt.sc/Nrp8aXOcbLbs

Test result-

The patch works as expected.

@sabernhardt
4 months ago

before the patch, the font size for any Calendar block is 1.8rem at a screen width larger than 700 pixels

@sabernhardt
4 months ago

with the patch, the default font size increases to 2.1rem while custom sizes are supported

#5 @sabernhardt
4 months ago

  • Keywords changes-requested added; needs-testing removed
  • Summary changed from Twenty Twenty theme calendar block is having issue with font size. to Twenty Twenty: Calendar block does not apply font size from block option

Related: #56157

Since its initial version, Twenty Twenty has specified a smaller size for tables, either 1.6rem for small screens or 1.8rem for screens wider than 700 pixels.

If the Calendar block is ever inserted inside a post, inherit would increase the font size for any Calendar block that does not specify its own size. The .entry-content class sets the size at 1.8rem or 2.1rem for larger screens.

In the widget area, where the Calendar block usually belongs, the proposed change would set the default font size to 1.8rem for all screens.

To avoid unexpected changes, the patch should only apply when the user selects a font size for the block.

#6 @sabernhardt
4 months ago

  • Version changed from 6.4 to 6.1

#7 @darshitrajyaguru97
4 months ago

Test report for https://core.trac.wordpress.org/attachment/ticket/59996/59996.patch

Environment:
===========
PHP: 8.1.9
WordPress: 6.4
OS: Windows
Server: nginx
Theme: Twenty Twenty
Plugin: No Plugin

Screenshots:
Before Patch
Backend: https://prnt.sc/-tPBJjH7qnNB
Frontend: https://prnt.sc/ArS10T9x-yTS

After Patch
Backend: https://prnt.sc/-tPBJjH7qnNB
Frontend: https://prnt.sc/8hcvdm6OeK77

After Applying patch it's working well.

Last edited 4 months ago by darshitrajyaguru97 (previous) (diff)

@shailu25
4 weeks ago

Patch Updated

#8 @shailu25
4 weeks ago

  • Keywords changes-requested removed

Updated Patch as per suggested in above comment.

Last edited 4 weeks ago by shailu25 (previous) (diff)
Note: See TracTickets for help on using tickets.