Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #60003, comment 3


Ignore:
Timestamp:
12/11/2023 08:56:19 PM (6 months ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #60003, comment 3

    initial v1  
    1 The cause of an error or warning is always important. Without an example of //how// the code fails, how can developers know that the hardening fix is good enough? It might need to check precisely whether the type is either a string or an array. I also do not know what the `wp_match_mime_types()` function should return if the second parameter is not an acceptable type.
     1The cause of an error or warning is always important. Without an example of //how// the code fails, how can developers know that the hardening fix is good enough? It might need to check precisely whether the type is either a string or an array of strings (as `block_core_gallery_render()` does). I also do not know what the `wp_match_mime_types()` function should return if the second parameter is not an acceptable type.
    22
    33I did not close this ticket (or even suggest closing it). If the problematic code is in a plugin, it likely needs to be reported and fixed there so the plugin operates as intended. If something in Core causes the error, the Core team needs to know where to find it.