Make WordPress Core

Opened 2 years ago

Last modified 2 weeks ago

#60012 new defect (bug)

Twenty Sixteen: Pullquote block Appearance setting is not working properly

Reported by: ashikur698's profile ashikur698 Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch close 2nd-opinion
Focuses: Cc:

Description (last modified by sabernhardt)

The appearance of PullQuote blocks is not working correctly in Twenty-Sixteen. Though there are many options like semi-bold, medium, italic, etc. it seems only two things get applied no matter what I choose. It's either normal, bold or extra bold. And the extra bold is just as same as Black. No changes with any kind of italic.

Steps to reproduce the issue:-

  1. Activate Twenty Sixteen theme.
  2. Choose Pullquote block.
  3. Write something in Citation
  4. Change the appearance

Attachments (2)

60012.diff (859 bytes) - added by sabernhardt 2 weeks ago.
removes font-style rule from citation, to use block library style
60012.match-italic.diff (1.3 KB) - added by sabernhardt 2 weeks ago.
removes font-style rule from citation, and sets the citation to italic when the block is italicized

Download all attachments as: .zip

Change History (7)

#1 @ashikur698
2 years ago

  • Keywords needs-patch 2nd-opinion added

#2 @sabernhardt
2 years ago

  • Component changed from General to Bundled Theme
  • Summary changed from Twenty Sixteen : PullQuote block Appereance is not working properly to Twenty Sixteen: Pullquote block Appearance setting is not working properly

Twenty Sixteen has three weights for Merriweather:

  • Regular 400
  • Bold 700
  • Black 900

Merriweather also has the Light 300 weight available, though I would rather not bundle that set of font files too in an effort to support only one more weight option in a block's Appearance settings. It still would not be accurate for 100, 200, 500, 600 or 800.

Twenty Sixteen has had rather opinionated italic choices in the Pullquote block and with blockquote elements before the block editor was publicly available. People who do not like that styling could have added custom CSS or chosen a different theme by now.

Someone who chooses an Italic option when the default is italic likely would want the citation italicized too. However, selecting one of the normal Appearance options would not always mean that the user wants both the paragraph and the citation to have the normal font-style.

This could italicize the citation:

.wp-block-pullquote[style*="font-style:italic"] cite {
  font-style: italic;
}

#3 @karmatosed
21 months ago

  • Keywords 2nd-opinion removed

#4 @karmatosed
21 months ago

  • Milestone changed from Awaiting Review to Future Release

@sabernhardt
2 weeks ago

removes font-style rule from citation, to use block library style

@sabernhardt
2 weeks ago

removes font-style rule from citation, and sets the citation to italic when the block is italicized

#5 @sabernhardt
2 weeks ago

  • Description modified (diff)
  • Keywords has-patch close 2nd-opinion added; needs-patch removed

GB11610 started to deprecate the Pullquote block for WordPress 7.0, so it might not be worth editing Twenty Sixteen's CSS (much) for the block at this time. However, the citation incorrectly appears italicized in the editor, and the normal value (on the front) is redundant.

[43799] set the font-style to an invalid none value on the front and italic in the editor. [52004] then corrected the value to normal, but block-library/theme.css has set the font-style to normal since WordPress 5.0 (GB9763).

Both patches remove the font-style rule, and 60012.match-italic.diff also would reflect the choice of an Italic Appearance option in the citation.

Note: See TracTickets for help on using tickets.