Make WordPress Core

Opened 10 months ago

Last modified 7 months ago

#60023 new defect (bug)

Fixed force_ssl_admin to always return bool

Reported by: pbearne's profile pbearne Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch
Focuses: Cc:

Description

this function can be passed a random string
where the Gobal value set by is used we check if it is not empty
the doc say to set a bool but is allows you set any value eg 'false' which on empty
So I have added a cast to make sure the value set is bool
see pre fix tests
https://core.trac.wordpress.org/ticket/60018

Change History (2)

This ticket was mentioned in PR #5731 on WordPress/wordpress-develop by @pbearne.


10 months ago
#1

  • Keywords has-patch has-unit-tests added

#2 @swissspidy
7 months ago

  • Keywords needs-patch added; has-patch has-unit-tests removed
Note: See TracTickets for help on using tickets.