![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#60034 closed defect (bug) (fixed)
Fix the period in the in-line comment of wp_block_theme_activate_nonce()
| Reported by: | stevenlinx | Owned by: | isabel_brison |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.5 |
| Component: | Themes | Version: | 6.3 |
| Severity: | minor | Keywords: | good-first-bug has-patch commit |
| Cc: | Focuses: | template |
Description
In the in-line comment section of wp_block_theme_activate_nonce() , there is a line:
@see https://github.com/WordPress/gutenberg/pull/41836.
https://core.trac.wordpress.org/browser/tags/6.4/src/wp-includes/theme-previews.php#L64
Why is this a problem?
The period at the end of the URL is being linked and causing GitHub to think you're trying to create a PR (comparing forks).
The link is being is displays on
https://developer.wordpress.org/reference/functions/wp_block_theme_activate_nonce/
The viewer clicks the link to view PR ticket in question, not to create a PR.
Suggested Fix
Remove the period.
Change History (6)
#1
@
3 years ago
- Component General → Themes
- Focuses template added
- Keywords needs-patch good-first-bug added
- Milestone Awaiting Review → 6.5
- Version → 6.3
This ticket was mentioned in PR #5741 on WordPress/wordpress-develop by @isabel_brison.
3 years ago
#3
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/60034
Removes period from end of PR link so the link will work correctly in developer docs.
@isabel_brison commented on PR #5741:
3 years ago
#6
Committed in r57171.
Good catch, introduced in [56199] / #58712.