#60034 closed defect (bug) (fixed)
Fix the period in the in-line comment of wp_block_theme_activate_nonce()
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.5 | Priority: | normal |
| Severity: | minor | Version: | 6.3 |
| Component: | Themes | Keywords: | good-first-bug has-patch commit |
| Focuses: | template | Cc: |
Description
In the in-line comment section of wp_block_theme_activate_nonce() , there is a line:
@see https://github.com/WordPress/gutenberg/pull/41836.
https://core.trac.wordpress.org/browser/tags/6.4/src/wp-includes/theme-previews.php#L64
Why is this a problem?
The period at the end of the URL is being linked and causing GitHub to think you're trying to create a PR (comparing forks).
The link is being is displays on
https://developer.wordpress.org/reference/functions/wp_block_theme_activate_nonce/
The viewer clicks the link to view PR ticket in question, not to create a PR.
Suggested Fix
Remove the period.
Change History (6)
#1
@
12 months ago
- Component changed from General to Themes
- Focuses template added
- Keywords needs-patch good-first-bug added
- Milestone changed from Awaiting Review to 6.5
- Version set to 6.3
This ticket was mentioned in PR #5741 on WordPress/wordpress-develop by @isabel_brison.
12 months ago
#3
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/60034
Removes period from end of PR link so the link will work correctly in developer docs.
#5
@
12 months ago
- Owner set to isabel_brison
- Resolution set to fixed
- Status changed from new to closed
In 57171:
@isabel_brison commented on PR #5741:
12 months ago
#6
Committed in r57171.
Good catch, introduced in [56199] / #58712.