Fix the declared Lodash version

[jadpm]

The Lodash version stated in package.json and loaded by Core is 4.17.21. However, we declare it as 4.17.19 in script-loader.php.

Sync the declared version number with the one that is loaded. It seems that in the last library update, the declared version was not updated to match it.

Trac ticket: https://core.trac.wordpress.org/ticket/60048

[swissspidy]

Good catch! And thanks for the PR.

It would be super cool if we could add a PHPUnit test that catches this in the future:

1. Call wp_default_packages_vendor
2. Loop through the registered vendor scripts
3. Compare their version with what's in package.json
4. Fail if there is a mismatch

See: https://core.trac.wordpress.org/ticket/60048

Based on @swissspidy's suggestion, I added a simple test to ensure the registered version is the same as the version loaded via package.json.

The test only includes a subset of scripts since the others are renamed. Rather than adjusting the way scripts are loaded, this makes the list of which scripts to test a hard-coded version.

This incorporates the fix from #5755.

[jorbin]

In 57185:

External Libraries: For Lodash, sync the declared version number with the one that is loaded.

In [50941] the version of lodash was updated, however the version inside wp_default_packages_vendor was not updated at the same time. This updates the version to correctly reflect the version that is loaded.

Also adds some basic tests for the scripts in wp_default_packages_vendor that match the name of the package from package.json to help prevent errors like this in the future.

Props jadpm, jorbin, swissspidy.
Fixes #60048. See #52991.

Thanks! This was merged in https://core.trac.wordpress.org/changeset/57185

Merged in https://core.trac.wordpress.org/changeset/57185

[TobiasBg]

@jorbin: The PHP function name test_wp_default_packages_vendor_lodash should probably not have the _lodash, to not create confusion (as the test actually covers multiple libraries)?

[jorbin]

In 57187:

Build/Test: Update name of test to show its breadth.

The test covers multiple libraries, not just lodash.

Follow up to [57185].

Props TobiasBg.
Fixes #60048.

[skithund]

@jorbin $provider = array(); ​in _scripts_from_package_json() might be unnecessary?