Add required attribute to username and password field in wp_login_form function.

[alesflex]

Add required attribute to username and password field in wp_login_form function.

[sabernhardt]

Related: #32510

[joedolson]

There could be some side-effects to adding this for tools like social sign in, single sign on, etc., but it's worth exploring.

At a minimum, it should be possible to pass the required attribute to the function in the arguments array, even if they aren't added by default.

This will need some testing with extensions that include login mechanisms, particularly those that have any kind of custom bypass or handling.

'required_username' and 'required_password' added to defaults. By default, both are set to false. So required attribute will not add to input fields. If set to true in $args for wp_login_form(), it will add the required attribute to the respective input field.

Trac ticket: https://core.trac.wordpress.org/ticket/60062

E.g.

 *     @type bool   $required_username Whether the username field has the 'required' attribute. Default false.
 *     @type bool   $required_password Whether the password field has the 'required' attribute. Default false.

[rcreators]

@joedolson Requested changes has been amended.

@joedolson Can you check and approve changes?

@Rcreators Added some comments if you can review please.

@Rajinsharwar Requested changes amended.

[joedolson]

Since we've decided to go with adding the arguments only, no extension testing is required. Extenders can choose to add the arguments to their implementations and test at that point. But at least it's now possible to add the required attributes to the login form output.

Testing:

• Call wp_login_form() with default arguments. Confirm that the input fields are not marked as required.
• Call wp_login_form() with the required_username and required_password fields set to 'true'. Verify that the input fields have the required attribute.

[rajinsharwar]

I have tested the PR: 6352. And found that:

1. With none of the required-x argument set: ​https://prnt.sc/-ez4buphF0Lv ✅
2. With only 'required_password' => true: ​https://prnt.sc/sIwfGuvnVvpL ✅
3. With only 'required_username' => true: ​https://prnt.sc/4D4WcIftSzKh ✅
4. With both required-x set: ​https://prnt.sc/T24XoX0uqUsI ✅

I believe this is good to be committed.

[audrasjb]

Hi there,

Thanks for working on this. The final patch honestly results more in an enhancement than a bugfix. But as it doesn't introduce any change for extenders by default, let's mark it for commit. Self assigning so it can ship before beta 2.

[audrasjb]

In 58382:

Login and Registration: Add required attribute to username and password fields in wp_login_form().

These attributes are needed to indicate that both fields are required. This changeset doesn't add the attribute by default but allows extenders to enable it by passing true to the $required_username and $required_password to wp_login_form() arguments array.

Props alesflex, sabernhardt, joedolson, rcreators, rajinsharwar.
Fixes #60062.

[audrasjb]

Adding needs-dev-note so it's mentioned in the Login and Registration devnote or in the Misc Changes devnote.

committed in https://core.trac.wordpress.org/changeset/58382

[joedolson]

Misc. dev note:

The wp_login_form() function has two new array arguments: required_username and required_password. Passing true to these arguments adds the 'required' attribute to the input fields.

$args = array(
    'required_username' => true,
    'required_password' => true,
);
wp_login_form( $args );

There is no change to the default field output.

[audrasjb]

Thanks @joedolson for the note.
Added to the draft post.