WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #60064, comment 2


Ignore:
Timestamp:
12/18/2023 09:50:01 PM (13 months ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #60064, comment 2

    initial v1  
    11The bug is in BuddyPress 12.0.0, not the themes, and that should be fixed in 12.1.0.
    22
    3 While the BuddyPress 12 bug would not affect all [https://wpdirectory.net/search/01HHRQV1V2T8FFN76EGY3Q0S18 1,917 themes] that use a `.no.js` selector, it probably still changed the display in hundreds of them. In addition to Twenty Twenty-One, which removes the `no-js` body class when JavaScript is enabled, the [https://wpdirectory.net/search/01HHRQW1SW2H0VJGNJ3B0Q2NQK 12 themes that target `html.no-js`] should not break. Any similar bugs that might occur in a future plugin theoretically would be easier to find in one of the bundled themes than in one of the others.
     3While the BuddyPress 12 bug would not affect all [https://wpdirectory.net/search/01HHRQV1V2T8FFN76EGY3Q0S18 1,917 themes] that use a `.no-js` selector, it probably changed the display in hundreds of them. In addition to Twenty Twenty-One, which removes the `no-js` body class when JavaScript is enabled, the [https://wpdirectory.net/search/01HHRQW1SW2H0VJGNJ3B0Q2NQK 12 themes that target `html.no-js`] should not break. Any similar bugs that might occur in a future plugin theoretically would be easier to find in one of the bundled themes than in one of the others.
    44
    55The [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#selectors CSS Coding Standards] encourages to "refrain from using over-qualified selectors," though sometimes it can be necessary. When it is, adding an explanatory comment usually is helpful.