WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 23 months ago

Last modified 21 months ago

#60078 closed defect (bug) (fixed)

Fix the Generic.Formatting.MultipleStatementAlignment.IncorrectWarning linter warning in WP_HTML_Tag_Processor

Reported by: antonvlasenko's profile antonvlasenko Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: HTML API Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

Backport ​https://github.com/WordPress/gutenberg/pull/57030 to Core.
The PR in question contains a small code style fix for the WP_HTML_Tag_Processor class, and it should be backported to Core to ensure that the two codebases are aligned.

Change History (7)

​@antonvlasenko commented on ​PR #5768:
2 years ago #2

cc @dmsnell

#3 @dmsnell
2 years ago

Looks good to me, thanks @antonvlasenko! We'll make sure to get this into ​https://github.com/WordPress/gutenberg/pull/57022 before we merge that one so your previous pre-backport doesn't get lost.

I can't approve this officially, but I approve ✅

​@dmsnell commented on ​PR #5768:
2 years ago #4

Thanks @anton-vlasenko - as noted in the Trac ticket, this is great. I'm unable to accept it but it has my approval.

#5 @ironprogrammer
23 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.5

As ​this ticket's PR has been reviewed and approved, I'm assigning it to 6.5 for commit consideration.

Thank you, @antonvlasenko and @dmsnell!

#6 @SergeyBiryukov
23 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57227:

Coding Standards: Correct alignment in WP_HTML_Tag_Processor::apply_attributes_updates().

This fixes an Equals sign not aligned correctly WPCS warning.

Follow-up to [57179].

Props antonvlasenko, dmsnell, ironprogrammer.
Fixes #60078.

​@SergeyBiryukov commented on ​PR #5768:
23 months ago #7

Thanks for the PR! Merged in r57227.

Note: See TracTickets for help on using tickets.