WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#6009 closed defect (bug) (fixed)

edit-comments.php ajax actions need tweaking

Reported by: mdawaffe Owned by: mdawaffe
Milestone: 2.5 Priority: high
Severity: normal Version: 2.5
Component: Administration Keywords: js ajax has-patch
Focuses: Cc:

Description

  1. Deleting comments looks strange; the JS effect is broken.
  2. Approving comments from "All comments" page makes them disappear.
  3. Approving comments doesn't update all of the "awaiting moderation" counts on the page.

Attached:

  1. Replaces jquery.color.js with version from trunk: http://dev.jquery.com/browser/trunk/plugins/color/jquery.color.js. This improves RGBA support which is necessary for Safari 3. It's still broken (http://dev.jquery.com/ticket/2281), but at least it doesn't completely die anymore.
  2. Cleans up background-color fades in wp-lists.js.
  3. Tidies up wp-lists.js to be more jQuery 1.2 friendly.
  4. Clean up wp-list's delete JS. slideUp doesn't work on TRs or other table elements (a known jQuery bug). Use fadeOut for these elements.
  5. Approve comments from "All comments" makes them glow and lose their "approve" link (rather than glowing and disappearing completely).
  6. Updates comment-count markup and JS so that all comment-count ("awaiting moderation") numbers get incremented/decremented correctly.

Attachments (1)

6009.diff (23.7 KB) - added by mdawaffe 6 years ago.

Download all attachments as: .zip

Change History (3)

mdawaffe6 years ago

comment:1 mdawaffe6 years ago

  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned

jquery.color.js will need to be re-minified if we want to keep doing that.

So far, everything's only been tested in FF 2.

comment:2 ryan6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7050]) Ajax tweaks for edit-comments.php from mdawaffe. fixes #6009

Note: See TracTickets for help on using tickets.