Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#60095 closed defect (bug) (fixed)

Update default PHP version used in local Docker Environment for older branches

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.4.3 Priority: normal
Severity: normal Version: 5.8
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

On October 26, 2023, the version of PHP Docker containers marked latest changed from PHP 7.4 to 8.2. This worked find for trunk and the 6.4 branch, however older branches that do not support PHP 8.2 are now running E2E tests on a version that was unsupported at the time.

This is affecting the 5.8-6.2 branches, but will also affect the 6.3 branch once latest is changed to utilize 8.3. The higher limit version of PHP should be hard coded into the .env file for these branches.

Change History (24)

This ticket was mentioned in PR #5780 on WordPress/wordpress-develop by @desrosj.


4 months ago
#1

  • Keywords has-patch added

This ticket was mentioned in PR #5781 on WordPress/wordpress-develop by @desrosj.


4 months ago
#2

This ticket was mentioned in PR #5783 on WordPress/wordpress-develop by @desrosj.


4 months ago
#3

This ticket was mentioned in PR #5784 on WordPress/wordpress-develop by @desrosj.


4 months ago
#4

This ticket was mentioned in PR #5785 on WordPress/wordpress-develop by @desrosj.


4 months ago
#5

This ticket was mentioned in PR #5786 on WordPress/wordpress-develop by @desrosj.


4 months ago
#6

#7 @desrosj
4 months ago

In 57198:

Build/Test Tools: Change the default value of LOCAL_PHP.

This changes the default value for LOCAL_PHP in the 6.4 branch from latest to 8.3-fpm to reflect the highest version of PHP this branch will support (with beta support).

After this change, future updates to the latest container built and published by the wpdev-docker-images repository will not cause failures in this branch.

While there are currently no failures in the 6.4 branch, the latest container was recently changed from using PHP 7.4 to 8.2 and caused failures in the 5.8-6.3 branches. Pinning a PHP version to this branch now will prevent that same scenario in the future. Going forward, this should be done at the time of branching.

Older branches already have specific PHP versions defined.

See #60095.

#9 @desrosj
4 months ago

In 57199:

Build/Test Tools: Change the default value of LOCAL_PHP.

This changes the default value for LOCAL_PHP in the 6.3 branch from latest to 8.2-fpm to reflect the highest version of PHP this branch will support (with beta support).

After this change, future updates to the latest container built and published by the wpdev-docker-images repository will not cause failures in this branch.

Follow up to [57198].

See #60095.

This ticket was mentioned in PR #5782 on WordPress/wordpress-develop by @desrosj.


4 months ago
#11

#12 @desrosj
4 months ago

In 57200:

Build/Test Tools: Change the default value of LOCAL_PHP.

This changes the default value for LOCAL_PHP in the 5.8 branch from latest to 8.0-fpm to reflect the highest version of PHP this branch will support (with beta support).

After this change, future updates to the latest container built and published by the wpdev-docker-images repository will not cause failures in this branch.

Follow up to [57198], [57198].

See #60095.

#14 @desrosj
4 months ago

In 57201:

Build/Test Tools: Change the default value of LOCAL_PHP.

This changes the default value for LOCAL_PHP in the 5.9 branch from latest to 8.1-fpm to reflect the highest version of PHP this branch will support (with beta support).

After this change, future updates to the latest container built and published by the wpdev-docker-images repository will not cause failures in this branch.

This also pins the version of PHP used in the E2E test workflow to PHP 8.0 to avoid deprecated notices related to #54914, which was not fixed until version 6.1.

Follow up to [57198], [57199], [57200].

See #60095.

#16 @desrosj
4 months ago

In 57202:

Build/Test Tools: Change the default value of LOCAL_PHP.

This changes the default value for LOCAL_PHP in the 6.0 branch from latest to 8.1-fpm to reflect the highest version of PHP this branch will support (with beta support).

After this change, future updates to the latest container built and published by the wpdev-docker-images repository will not cause failures in this branch.

This also pins the version of PHP used in the E2E test workflow to PHP 8.0 to avoid deprecated notices mostly related to #54914, which was not fixed until version 6.1.

Follow up to [57198], [57199], [57200], [57201].

See #60095.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


4 months ago

#19 @desrosj
4 months ago

In 57205:

Build/Test Tools: Change the default value of LOCAL_PHP.

This changes the default value for LOCAL_PHP in the 6.1 branch from latest to 8.2-fpm to reflect the highest version of PHP this branch will support (with beta support).

After this change, future updates to the latest container built and published by the wpdev-docker-images repository will not cause failures in this branch.

This also pins the version of PHP used in the E2E test workflow to PHP 8.0 to avoid deprecated notices mostly related to #54504, which were not fixed until version 6.2.

Follow up to [57198], [57199], [57200], [57201], [57202].

See #60095.

#21 @desrosj
4 months ago

In 57206:

Build/Test Tools: Change the default value of LOCAL_PHP.

This changes the default value for LOCAL_PHP in the 6.2 branch from latest to 8.2-fpm to reflect the highest version of PHP this branch will support (with beta support).

After this change, future updates to the latest container built and published by the wpdev-docker-images repository will not cause failures in this branch.

Follow up to [57198], [57199], [57200], [57201], [57202], [57205].

See #60095.

#23 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed
  • Version set to 5.8

Going to close this out because the goal of the ticket has been accomplished.

The E2E tests are still failing for the 6.2 branch, though it is likely due to a different reason.

I've gone and updated the Core Handbook to include a checklist item to change the LOCAL_PHP value from latest after branching: https://make.wordpress.org/core/handbook/about/release-cycle/releasing-major-versions/#branching-before-release.

This ticket was mentioned in Slack in #core-performance by desrosj. View the logs.


4 months ago

Note: See TracTickets for help on using tickets.