Make WordPress Core

Opened 4 months ago

Closed 7 days ago

#60097 closed defect (bug) (fixed)

Remove target="_blank" from help tab in privacy-related screens

Reported by: sabernhardt's profile sabernhardt Owned by: joedolson's profile joedolson
Milestone: 6.6 Priority: normal
Severity: normal Version: 5.7
Component: Help/About Keywords: target-blank has-patch commit
Focuses: accessibility, administration, privacy, ui-copy Cc:

Description

Related: #23432, #43994, #52970

Several help links have stopped opening in a new tab/window (ticket:23432#comment:36). Similarly, the links for how to add plugin support of either exporting or erasing personal data should not force opening in a separate tab.

Attachments (4)

60097.diff (2.1 KB) - added by sabernhardt 4 months ago.
removes target="_blank" from two links, tweaks the sentences' text (using the words "support for" in both), and rearranges paragraphs
60097.1.diff (2.2 KB) - added by joedolson 7 days ago.
Remove 'support for' from erase Help text
60097.2.diff (1.0 KB) - added by joedolson 7 days ago.
Follow up
60097.3.diff (4.3 KB) - added by joedolson 7 days ago.
New patch, now that I'm actually committing to *trunk*

Download all attachments as: .zip

Change History (16)

@sabernhardt
4 months ago

removes target="_blank" from two links, tweaks the sentences' text (using the words "support for" in both), and rearranges paragraphs

#1 @sabernhardt
4 months ago

  • Keywords has-patch needs-copy-review added

As long as the strings would change, I also would like to

  1. remove "here" because the word is unnecessary and often unclear,
  2. move "learn more about" before the link so the link text is shorter,
  3. begin the plugin authors' sentence the same way on the Export Personal Data page as [53182] changed the sentence for the Erase Personal Data page,
  4. move the privacy guide paragraph before the sentence for plugin authors, and
  5. consider either adding "support for" in the link text for Export Personal Data or removing it from Erase Personal Data.

#2 @sabernhardt
4 months ago

  • Keywords target-blank added

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


6 weeks ago

#4 @joedolson
6 weeks ago

  • Milestone changed from Awaiting Review to 6.6
  • Owner set to joedolson
  • Status changed from new to accepted

#5 @joedolson
7 days ago

  • Keywords commit added; needs-copy-review removed

I think these are all good suggestions; my preference is to go more concise, so on point #5, I think we should remove 'support for' from the Erase screen. I think it's more direct, and the audience doesn't need the extra elaboration.

@joedolson
7 days ago

Remove 'support for' from erase Help text

#6 @sabernhardt
7 days ago

The first patch contained "support for" in both strings, and 60097.1.diff still has it in the export help text.

#7 @joedolson
7 days ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 58018:

Help/About: Accessibility: Remove target="_blank" from data eraser links.

Remove target="_blank" from two links to developer resources on adding the personal data eraser to plugins in the Help info for the privacy screens. Also rectifies differences between the export and erase screens for consistency and changes the order of paragraphs.

Props sabernhardt, joedolson.
Fixes #60097.

#8 @joedolson
7 days ago

Darn. I missed that. Having some trouble with my eyes.

#9 @joedolson
7 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@joedolson
7 days ago

Follow up

#10 @joedolson
7 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 58019:

Help/About: Text consistency follow-up to [58018].

Follow up to [58018]. Remove extra 'support for' from Export help link text.

Props sabernhardt.
Fixes #60097.

#11 @joedolson
7 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

OK, I just realized that I committed this to the 6.5 branch by accident. I assume that I failed to switch branches after my last merge during 6.5 RC. Reopening.

@joedolson
7 days ago

New patch, now that I'm actually committing to *trunk*

#12 @joedolson
7 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 58021:

Help/About: Accessibility: Remove target="_blank" from data eraser links.

Remove target="_blank" from two links to developer resources on adding the personal data eraser to plugins in the Help info for the privacy screens. Also rectifies differences between the export and erase text for consistency and changes the order of paragraphs.

Props sabernhardt, joedolson.
Fixes #60097.

Note: See TracTickets for help on using tickets.