WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 21 months ago

#60100 closed defect (bug) (fixed)

Remove target="_blank" from link for non-HTTPS local environments

Reported by: sabernhardt's profile sabernhardt Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.7 Priority: normal
Severity: normal Version: 5.9
Component: Application Passwords Keywords: target-blank has-patch commit
Focuses: accessibility, administration, ui-copy Cc:

Description (last modified by sabernhardt)

Related: #23432, #53658

The developer docs link for enabling Application Passwords in non-HTTPS local environments probably should not open in a new tab.

While losing changes is currently possible when the link opens in the same tab, that should have a different solution for any links clicked on the User Profile page (#40493).

Attachments (1)

60100.diff​ (738 bytes) - added by sabernhardt 2 years ago.
removes target="_blank" from link and adds a comma

Download all attachments as: .zip

Change History (11)

@sabernhardt
2 years ago

removes target="_blank" from link and adds a comma

#1 @sabernhardt
2 years ago

I also like adding a comma after "If this is a development website," and several translations have one there already (including ​UK English).

#2 @sabernhardt
2 years ago

  • Description modified (diff)

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
2 years ago

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
2 years ago

#6 @sabernhardt
2 years ago

  • Milestone changed from Awaiting Review to Future Release

#7 @joedolson
2 years ago

With [58137], this is unblocked.

#8 @joedolson
23 months ago

  • Milestone changed from Future Release to 6.7

This ticket was mentioned in ​PR #7094 on ​WordPress/wordpress-develop by ​@peterwilsoncc.
21 months ago #9

Trac ticket:

#10 @peterwilsoncc
21 months ago

  • Keywords commit added

This looks good to me and works as expected with [58137].

I've ​pushed up a PR to ensure the tests continue to pass prior to commit.

#11 @peterwilsoncc
21 months ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 58820:

Application Passwords: Open documentation link in same window.

Removes the target to to documentation for ​setting the environment type for applications passwords so the tabs open in the same window.

This follows [58137] which added a confirmation prompt for users navigating away from the profile edit screen if they have changed data without saving it.

Props sabernhardt, joedolson.
Fixes #60100.

Note: See TracTickets for help on using tickets.