Unused $body_id variable on the media-upload.php file.

[upadalavipul]

I have reviewed the media.php file code and found the $body_id variable is unused. So I think as per the coding standard we need to remove the $body_id variable here.

files: wp-admin/media-upload.php

[SergeyBiryukov]

Hi there, thanks for the patch!

The $body_id global is used in wp_iframe() and iframe_header().

wp_media_upload_handler() calls wp_iframe() with media_upload_type_form() as a callback printing the content, which in turn loads the media-upload.php file where $body_id is defined.

These are legacy media functions, but they are still kept for backward compatibility, so I don't think the $body_id global should be removed, as that might cause unnecessary breakage.

[sabernhardt]

The global is used by functions in other files, so I'll close the ticket.