Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#60119 closed defect (bug) (fixed)

Pattern Category: change show_tagcloud to false

Reported by: wildworks Owned by: youknowriad
Priority: normal Milestone: 6.5
Component: Taxonomy Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Note: This ticket is for backporting PHP changes made in Gutenberg to core.

​https://github.com/WordPress/gutenberg/pull/57212

Pattern Categories appears as a selectable taxonomy in the tag cloud block or tag cloud widget. I think this is unintended, and it is necessary to set show_tagcloud to false so that it cannot be used with tag cloud.

Change History (7)

This ticket was mentioned in ​PR #5805 on ​WordPress/wordpress-develop by ​@wildworks.


3 years ago
#1

  • Keywords has-patch added

​@mukesh27 commented on ​PR #5805:


3 years ago
#2

Thanks for the PR! LGTM and approved the PR.

Q: Do we needs to mention in docs that now Pattern Category did not show show_tagcloud?

​@wildworks commented on ​PR #5805:


3 years ago
#3

Thank you for your review! I think the Pattern categories are used to categorize patterns only on the dashboard or Site Editor, and are not intended to be displayed on the front end.

Therefore, I think that this change is a bug fix rather than a specification change, and no documentation is necessary.

#4 @youknowriad
3 years ago

  • Owner set to youknowriad
  • Resolution → fixed
  • Status new → closed

In 57331:

Editor: Set show_tagcloud to false for Pattern Categories.

Pattern Categories is a taxonomy used to categories the patterns in the site editor.
It is not meant to be shown in the frontend and show tag clouds.

Props wildworks, mukesh27.
Fixes #60119.

​@youknowriad commented on ​PR #5805:


3 years ago
#5

Thanks for the backport, this has been committed in https://core.trac.wordpress.org/changeset/57331

#6 @kebbet
3 years ago

Please milestone the ticket to 6.5 @youknowriad, thanks!

#7 @youknowriad
3 years ago

  • Milestone Awaiting Review → 6.5
Note: See TracTickets for help on using tickets.