Make WordPress Core

Opened 2 months ago

Last modified 8 days ago

#60129 new task (blessed)

Comment on a PR when no Trac ticket is included

Reported by: desrosj's profile desrosj Owned by:
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: good-first-bug has-patch
Focuses: Cc:

Description

When contributing to Core using a pull request on GitHub, a Trac ticket is required for the contribution to be considered.

Even though the pull request template notes this, it's easy to forget or overlook.

Adding a job in the Pull Request Comments workflow to add a reminder comment when a Trac ticket link is missing is an easy way to help avoid contributions being lost in the shuffle.

Change History (6)

This ticket was mentioned in PR #6060 on WordPress/wordpress-develop by @anamarijapapic.


3 weeks ago
#1

  • Keywords has-patch added; needs-patch removed

When contributing to Core using a pull request on GitHub, a Trac ticket is required for the contribution to be considered.

Even though the pull request template notes this, it's easy to forget or overlook.

Adding a job in the Pull Request Comments workflow to add a reminder comment when a Trac ticket link is missing is an easy way to help avoid contributions being lost in the shuffle.

Trac ticket: https://core.trac.wordpress.org/ticket/60129

This ticket was mentioned in PR #6088 on WordPress/wordpress-develop by @desrosj.


2 weeks ago
#2

Trac ticket:

@desrosj commented on PR #6060:


13 days ago
#3

Was thinking about this a bit more today. I think we should also attempt to check if a previous comment exists to avoid multiple comments for the same thing on a PR.

@anamarijapapic commented on PR #6060:


13 days ago
#4

Thank you for the review @desrosj and @peterwilsoncc!

I'll make the requested changes in the next few days when I have some free time. Feel free to let me know if you have any further suggestions!

This ticket was mentioned in Slack in #core by desrosj. View the logs.


11 days ago

#7 @swissspidy
8 days ago

  • Type changed from defect (bug) to task (blessed)
Note: See TracTickets for help on using tickets.