WordPress.org
Get WordPress

Make WordPress Core

Opened 10 months ago

Closed 9 months ago

Last modified 8 months ago

#60136 closed enhancement (fixed)

Allow default duotone styles if not explicitly disabled in theme.json.

Reported by: isabel_brison's profile isabel_brison Owned by: isabel_brison's profile isabel_brison
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: Editor Keywords: has-patch add-to-field-guide
Focuses: Cc:

Description

Default duotone presets should be available with block themes if they're not explicitly disabled in theme.json, and with all classic themes.

Previously this wasn't an option as duotone filters were being output on every page whether used or not, but that has since been fixed (see ​https://github.com/WordPress/gutenberg/pull/49103), so it should be fine to enable them again.

This syncs the change from ​https://github.com/WordPress/gutenberg/pull/57191

Change History (4)

This ticket was mentioned in ​PR #5817 on ​WordPress/wordpress-develop by ​@isabel_brison.
10 months ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/60136

Syncs changes from ​https://github.com/WordPress/gutenberg/pull/57191.

Not sure if the previous behaviour was being tested, and if not, might it be worth adding a test for this somewhere?

#2 @isabel_brison
9 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 57260:

Editor: Allow default duotone styles if not explicitly disabled in theme.json.

Removes setting that disabled default duotone palette from being output in themes without theme.json.

Props andrewserong.
Fixes #60136.

​@isabel_brison commented on ​PR #5817:
9 months ago #3

Thanks for the review! Committed in r57260.

#4 @stevenlinx
8 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.