WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#60146 closed defect (bug) (fixed)

$global Should add after @since according to PHP Documentation Standards in wp-settings.php

Reported by: shailu25 Owned by: SergeyBiryukov
Priority: normal Milestone: 6.5
Component: General Version:
Severity: trivial Keywords: has-patch commit
Cc: Focuses: docs, coding-standards

Description

In wp-settings.php file

$global Should add after @since according to ​PHP Documentation Standards

Attachments (2)

60146.patch​ (2.4 KB ) - added by shailu25 3 years ago.
Patch Added
60146.2.patch​ (2.7 KB ) - added by shailu25 3 years ago.
Patch Updated

Download all attachments as: .zip

Change History (9)

@shailu25
3 years ago

Patch Added

#1 @shailu25
3 years ago

  • Keywords has-patch added

#2 @shailu25
3 years ago

  • Version → trunk

#3 @mukesh27
3 years ago

  • Focuses coding-standards added
  • Keywords needs-refresh added
  • Milestone Awaiting Review → 6.5
  • Version trunk

Thanks for ticket and patch!

Could you please update ​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-settings.php#L56-L57 as it missing in patch.

@shailu25
3 years ago

Patch Updated

#4 @shailu25
3 years ago

I have Updated Patch as per Suggested.

#5 @shailu25
3 years ago

  • Keywords needs-refresh removed

#6 @mukesh27
3 years ago

  • Keywords commit added

Thanks @shailu25 for the update.

@audrasjb could you please review when you get some moment.

#7 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 57320:

Docs: Correct the placement of @global tags in wp-settings.php.

Props shailu25, mukesh27.
Fixes #60146.

Note: See TracTickets for help on using tickets.