Missing $previous_status argument in post trash hooks causes fatal error

[joelcj91]

In WordPress 6.3.0, the $previous_status argument was added to the pre_trash_post, wp_trash_post, and trashed_post hooks in wp-includes/post.php. However, this argument was not added to the corresponding hooks in wp-includes/class-wp-customizer-manager.php. This inconsistency leads to a fatal error when the code assumes the presence of the $previous_status argument in Customizer-related contexts.

[joelcj91]

First patch

[mukesh27]

Related to [56043]/#58392

[SergeyBiryukov]

Hi there, thanks for the patch! Looks good :)

[SergeyBiryukov]

In 57238:

Customize: Pass the previous status to post trash hooks when trashing a changeset.

This ensures that the correct number of arguments is passed to post trash hooks in WP_Customize_Manager::trash_changeset_post(), which bypasses wp_trash_post().

Follow-up to [56043].

Props joelcj91, mukesh27.
Fixes #60183.

[SergeyBiryukov]

In 57241:

Tests: Add a unit test for post trash hooks executed when trashing a changeset.

The test ensures that the correct number of arguments is passed to post trash hooks in WP_Customize_Manager::trash_changeset_post(), which bypasses wp_trash_post().

Follow-up to [56043], [57238].

See #60183.

[SergeyBiryukov]

In 57242:

Tests: Add a @ticket reference for WP_Customize_Manager::trash_changeset_post() test.

Follow-up to [56043], [57238], [57241].

Props mukesh27.
See #60183.