Context Navigation

← Previous Ticket
Next Ticket →

#60183 closed defect (bug) (fixed)

Missing $previous_status argument in post trash hooks causes fatal error

Reported by:	joelcj91	Owned by:	joelcj91
Priority:	normal	Milestone:	6.5
Component:	Posts, Post Types	Version:	6.3
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

In WordPress 6.3.0, the $previous_status argument was added to the pre_trash_post, wp_trash_post, and trashed_post hooks in wp-includes/post.php. However, this argument was not added to the corresponding hooks in wp-includes/class-wp-customizer-manager.php. This inconsistency leads to a fatal error when the code assumes the presence of the $previous_status argument in Customizer-related contexts.

Attachments (1)

60183.diff (1.8 KB ) - added by joelcj91 3 years ago.: First patch

Download all attachments as: .zip

Change History (6)

@joelcj91
3 years ago

Attachment 60183.diff added

First patch

#1 @mukesh27
3 years ago

Focuses php-compatibility removed
Severity major → normal

Related to [56043]/#58392

#2 @SergeyBiryukov
3 years ago

Milestone Awaiting Review → 6.5

Hi there, thanks for the patch! Looks good :)

#3 @SergeyBiryukov
3 years ago

Resolution → fixed
Status assigned → closed

In 57238:

Customize: Pass the previous status to post trash hooks when trashing a changeset.

This ensures that the correct number of arguments is passed to post trash hooks in WP_Customize_Manager::trash_changeset_post(), which bypasses wp_trash_post().

Follow-up to [56043].

Props joelcj91, mukesh27.
Fixes #60183.

#4 @SergeyBiryukov
3 years ago

In 57241:

Tests: Add a unit test for post trash hooks executed when trashing a changeset.

The test ensures that the correct number of arguments is passed to post trash hooks in WP_Customize_Manager::trash_changeset_post(), which bypasses wp_trash_post().

Follow-up to [56043], [57238].

See #60183.

#5 @SergeyBiryukov
3 years ago

In 57242:

Tests: Add a @ticket reference for WP_Customize_Manager::trash_changeset_post() test.

Follow-up to [56043], [57238], [57241].

Props mukesh27.
See #60183.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#60183 closed defect (bug) (fixed)

Missing $previous_status argument in post trash hooks causes fatal error

Description

Attachments (1)

Change History (6)

@joelcj91 3 years ago

#1 @mukesh27 3 years ago

#2 @SergeyBiryukov 3 years ago

#3 @SergeyBiryukov 3 years ago

#4 @SergeyBiryukov 3 years ago

#5 @SergeyBiryukov 3 years ago