Remove, from code comments, use of the expression "sanity check" (and variations)

[dartiss]

"Sanity check" is an ableist term, which we should reduce usage of. Although some functions exist making use of it, I'm not going to suggest changes are made to these, due to the creation of some incompatibility issues as a result.

However, there are 22 uses of this term (or variations of) across 16 files in core comments. My attached diffs will replace the term with "confidence check".

You read more about the concern around this language here: ​https://gist.github.com/seanmhanson/fe370c2d8bd2b3228680e38899baf5cc#

Let me know if you have any further questions about any of this.

[hellofromTonya]

Hello @dartiss,

Welcome back to WordPress Core :) Thank you for this ticket and the scope of work you've submitted.

I agree with you. The term "sanity check" needs to change to replace the word "sanity" with "confidence".

Moving this ticket into 6.5, self-assigning for patch review and commit.

Changes "sanity check" to "confidence check".

Applies the following patches:

• https://core.trac.wordpress.org/attachment/ticket/60187/class-pclzip.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/class-plugin-upgrader.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/class-theme-upgrader.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/class-wp-tax-query.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/class-wpdb.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/cron.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/functions.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/install.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/post.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/taxonomy.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/template-functions.php.diff
• https://core.trac.wordpress.org/attachment/ticket/60187/update-core.php.diff

Applies the following JS patches but in the js/_enqueues/ folder instead of in src/wp-admin/js:

• https://core.trac.wordpress.org/attachment/ticket/60187/post.js.diff gets applied in the src/js/_enqueues/admin/post.js file.
• https://core.trac.wordpress.org/attachment/ticket/60187/form_utils.js.diff gets applied in src/js/_enqueues/vendor/tinymce/utils/form_utils.js.
• https://core.trac.wordpress.org/attachment/ticket/60187/theme.js.diff gets applied in src/js/_enqueues/wp/theme.js.

Removes for sanity from:

• src/wp-includes/shortcodes.php

Trac ticket: https://core.trac.wordpress.org/ticket/60187

[hellofromTonya]

Patch: ​https://github.com/WordPress/wordpress-develop/pull/5838

Combines all of the patches in this ticket (thus far) and adds a few missing instances such as for sanity and in tests.

Marking for commit. Will prep shortly.

[hellofromTonya]

In 57239:

Docs: Replace "sanity" with "confidence" for inclusive language.

The phrase "sanity check" unnecessarily references mental health. It's an old phrase used to denote an extra step in verifying code works as expected.

“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”

While "sanity check" is a well-known phrase with a specific meaning, "confidence check" is a direct replacement that is more clear of its intent while being more inclusive.

Words matter.

Follow-up to [49216], [46271], [40583], [38832], [38637], [37409], [33359], [32162], [30346], [30345], [30238], [30055], [29902], [28763], [26141], [25002], [22227], [13428], [12148], [11025], [8927].

Props dartiss, hellofromTonya.
Fixes #60187.

Committed via https://core.trac.wordpress.org/changeset/57239.