Make WordPress Core

Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#60187 closed enhancement (fixed)

Remove, from code comments, use of the expression "sanity check" (and variations)

Reported by: dartiss's profile dartiss Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.5 Priority: normal
Severity: minor Version:
Component: General Keywords: has-patch commit
Focuses: docs Cc:

Description

"Sanity check" is an ableist term, which we should reduce usage of. Although some functions exist making use of it, I'm not going to suggest changes are made to these, due to the creation of some incompatibility issues as a result.

However, there are 22 uses of this term (or variations of) across 16 files in core comments. My attached diffs will replace the term with "confidence check".

You read more about the concern around this language here: https://gist.github.com/seanmhanson/fe370c2d8bd2b3228680e38899baf5cc#

Let me know if you have any further questions about any of this.

Attachments (16)

class-pclzip.php.diff (652 bytes) - added by dartiss 6 months ago.
class-plugin-upgrader.php.diff (685 bytes) - added by dartiss 6 months ago.
class-theme-upgrader.php.diff (728 bytes) - added by dartiss 6 months ago.
class-wp-tax-query.php.diff (606 bytes) - added by dartiss 6 months ago.
class-wpdb.php.diff (1.3 KB) - added by dartiss 6 months ago.
cron.php.diff (356 bytes) - added by dartiss 6 months ago.
customize-controls.js.diff (672 bytes) - added by dartiss 6 months ago.
form_utils.js.diff (538 bytes) - added by dartiss 6 months ago.
functions.php.diff (1.1 KB) - added by dartiss 6 months ago.
install.php.diff (283 bytes) - added by dartiss 6 months ago.
post.js.diff (799 bytes) - added by dartiss 6 months ago.
post.php.diff (613 bytes) - added by dartiss 6 months ago.
taxonomy.php.diff (761 bytes) - added by dartiss 6 months ago.
template-functions.php.diff (571 bytes) - added by dartiss 6 months ago.
theme.js.diff (532 bytes) - added by dartiss 6 months ago.
update-core.php.diff (519 bytes) - added by dartiss 6 months ago.

Download all attachments as: .zip

Change History (21)

@dartiss
6 months ago

@dartiss
6 months ago

@dartiss
6 months ago

@dartiss
6 months ago

@dartiss
6 months ago

#1 @hellofromTonya
5 months ago

  • Component changed from Comments to General
  • Focuses docs added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 6.5
  • Owner set to hellofromTonya
  • Severity changed from normal to minor
  • Status changed from new to reviewing

Hello @dartiss,

Welcome back to WordPress Core :) Thank you for this ticket and the scope of work you've submitted.

I agree with you. The term "sanity check" needs to change to replace the word "sanity" with "confidence".

Moving this ticket into 6.5, self-assigning for patch review and commit.

This ticket was mentioned in PR #5838 on WordPress/wordpress-develop by @hellofromTonya.


5 months ago
#2

Changes "sanity check" to "confidence check".

Applies the following patches:

Applies the following JS patches but in the js/_enqueues/ folder instead of in src/wp-admin/js:

Removes for sanity from:

  • src/wp-includes/shortcodes.php

Trac ticket: https://core.trac.wordpress.org/ticket/60187

#3 @hellofromTonya
5 months ago

  • Keywords commit added

Patch: https://github.com/WordPress/wordpress-develop/pull/5838

Combines all of the patches in this ticket (thus far) and adds a few missing instances such as for sanity and in tests.

Marking for commit. Will prep shortly.

#4 @hellofromTonya
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 57239:

Docs: Replace "sanity" with "confidence" for inclusive language.

The phrase "sanity check" unnecessarily references mental health. It's an old phrase used to denote an extra step in verifying code works as expected.

“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”

While "sanity check" is a well-known phrase with a specific meaning, "confidence check" is a direct replacement that is more clear of its intent while being more inclusive.

Words matter.

Follow-up to [49216], [46271], [40583], [38832], [38637], [37409], [33359], [32162], [30346], [30345], [30238], [30055], [29902], [28763], [26141], [25002], [22227], [13428], [12148], [11025], [8927].

Props dartiss, hellofromTonya.
Fixes #60187.

Note: See TracTickets for help on using tickets.