Make WordPress Core

Opened 3 months ago

Last modified 3 months ago

#60197 new defect (bug)

Twenty Fifteen: List block list alignment issue.

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Description

I have reviewed the "list block" into the "Twenty Fifteen" theme and found that its UL list type is not displaying properly when we add the list background color.

Backend:
Issue: https://share.cleanshot.com/V3MPvcVPWT0xDLn6Wy2H

Front-end
https://share.cleanshot.com/dtmrQKGqnR6wbKPvkrTt

Thanks,

Attachments (5)

60197.patch (459 bytes) - added by viralsampat 3 months ago.
I have checked above mentioned issue and resolved it. Here, I have added my patch.
CleanShot 2024-01-05 at 13.59.31@2x.png (94.3 KB) - added by viralsampat 3 months ago.
CleanShot 2024-01-05 at 13.59.31@2x.2.png (94.3 KB) - added by viralsampat 3 months ago.
Resolved
60197.2.patch (513 bytes) - added by sabernhardt 3 months ago.
twenty-fifteen-vs-twenty-twenty-four.jpg (113.2 KB) - added by deepakvijayan 3 months ago.

Download all attachments as: .zip

Change History (10)

@viralsampat
3 months ago

I have checked above mentioned issue and resolved it. Here, I have added my patch.

#1 @devtanbir
3 months ago

@viralsampat I have tested your patch. But it's now working for me. See my example below:

editor-blocks.css

.wp-block-post-content ol.has-background,
.wp-block-post-content ul.has-background {
     padding: 1.25em 2.375em;
}

If I add like this, then it's work.

Last edited 3 months ago by devtanbir (previous) (diff)

#2 @sabernhardt
3 months ago

  • Component changed from Themes to Bundled Theme
  • Keywords has-patch added

I used .editor-styles-wrapper ul.has-background and .editor-styles-wrapper ol.has-background to override the zero padding on .edit-post-visual-editor ul:not(.wp-block-gallery) and .editor-styles-wrapper ol in editor-blocks.css.

#3 @deepakvijayan
3 months ago

@sabernhardt Not sure overriding .has-background would be the right way to go.

Since I can see this issue even when there is no background. I am attaching screenshots from themes "Twenty Fifteen" and "Twenty Twenty-Four" with no background colour selected for reference.

Let us keep it consistent as to what it's been currently used in "Twenty Twenty-Four".

#4 follow-up: @sabernhardt
3 months ago

Twenty Fifteen needs to remain consistent with the design decisions made for that theme nine years ago. People who prefer Twenty Twenty-Four can switch themes.

When no background color is defined, the lists are supposed to be in a "hanging punctuation" style (see #30374).

#5 in reply to: ↑ 4 @deepakvijayan
3 months ago

Replying to sabernhardt:

Twenty Fifteen needs to remain consistent with the design decisions made for that theme nine years ago. People who prefer Twenty Twenty-Four can switch themes.

When no background color is defined, the lists are supposed to be in a "hanging punctuation" style (see #30374).

I see. Adjusting the padding while .has-background is active would be the only option to go about it. I apologize for any confusion caused by my previous comment. Thank you for your hard work.

Note: See TracTickets for help on using tickets.