Make WordPress Core

Opened 3 months ago

Closed 2 months ago

Last modified 2 months ago

#60221 closed enhancement (fixed)

Document full list of features in `add_theme_support` docblock

Reported by: isabel_brison's profile isabel_brison Owned by: isabel_brison's profile isabel_brison
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

Follow up from #60118.

There are a few features currently missing from the list: border, block-templates and block-template-parts. Would be good to search the codebase for any others that might have snuck in and add them all :)

Change History (9)

#1 @mukesh27
3 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 6.5

#2 @up1512001
3 months ago

Hey, @mukesh27 I want to work on this ticket if its not assign to anyone.

#3 in reply to: ↑ description @up1512001
3 months ago

Replying to isabel_brison:

Follow up from #60118.

There are a few features currently missing from the list: border, block-templates and block-template-parts. Would be good to search the codebase for any others that might have snuck in and add them all :)

I have added all theme support list here please check if any support still missing.

  1. admin-bar
  2. align-wide
  3. appearance-tools
  4. automatic-feed-links
  5. block-template-parts
  6. block-templates
  7. border
  8. core-block-patterns
  9. custom-background
  10. custom-header
  11. custom-line-height
  12. custom-logo
  13. custom-spacing
  14. customize-selective-refresh-widgets
  15. custom-units
  16. dark-editor-style
  17. disable-custom-colours
  18. disable-custom-font-sizes
  19. disable-custom-gradients
  20. disable-layout-styles
  21. editor-color-palette
  22. editor-font-sizes
  23. editor-gradient-presets
  24. editor-styles
  25. featured-content
  26. html5
  27. link-color
  28. menus
  29. post-formats
  30. post-thumbnails
  31. responsive-embeds
  32. starter-content
  33. title-tag
  34. widgets
  35. widgets-block-editor
  36. wp-block-styles

@isabel_brison @mukesh27

Last edited 3 months ago by up1512001 (previous) (diff)

This ticket was mentioned in PR #6025 on WordPress/wordpress-develop by @up1512001.


3 months ago
#4

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/60221

  • This PR will update docblock for add_theme_support() of theme.php file.

### Updated param list.

* @param string $feature The feature being added. Likely core values include:
 *                          - 'admin-bar'
 *                          - 'align-wide'
 *                          - 'appearance-tools'
 *                          - 'automatic-feed-links'
 *                          - 'block-template-parts'
 *                          - 'block-templates'
 *                          - 'border'
 *                          - 'core-block-patterns'
 *                          - 'custom-background'
 *                          - 'custom-header'
 *                          - 'custom-line-height'
 *                          - 'custom-logo'
 *                          - 'customize-selective-refresh-widgets'
 *                          - 'custom-spacing'
 *                          - 'custom-units'
 *                          - 'dark-editor-style'
 *                          - 'disable-custom-colors'
 *                          - 'disable-custom-font-sizes'
 *                          - 'disable-custom-gradients'
 *                          - 'disable-layout-styles'
 *                          - 'editor-color-palette'
 *                          - 'editor-gradient-presets'
 *                          - 'editor-font-sizes'
 *                          - 'editor-styles'
 *                          - 'featured-content'
 *                          - 'html5'
 *                          - 'link-color'
 *                          - 'menus'
 *                          - 'post-formats'
 *                          - 'post-thumbnails'
 *                          - 'responsive-embeds'
 *                          - 'starter-content'
 *                          - 'title-tag'
 *                          - 'wp-block-styles'
 *                          - 'widgets'
 *                          - 'widgets-block-editor'

@up1512001 commented on PR #6025:


3 months ago
#5

Hey @mukeshpanchal27 could you please look into this PR?

@mukesh27 commented on PR #6025:


3 months ago
#6

@up1512001 left one review feedback.

#7 @swissspidy
3 months ago

@isabel_brison @poena Are you perhaps able to double check some of the version numbers in https://github.com/WordPress/wordpress-develop/pull/6025?

#8 @isabel_brison
2 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 57573:

Themes: update add_theme_support docblock.

Adds missing features to the list for the $feature parameter in add_theme_support().

Props up1512001, mukesh27, swissspidy, isabel_brison.
Fixes #60221.

@isabel_brison commented on PR #6025:


2 months ago
#9

Committed in r57573.

Note: See TracTickets for help on using tickets.