WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #60227, comment 32


Ignore:
Timestamp:
02/27/2024 07:10:15 AM (13 months ago)
Author:
costdev
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #60227, comment 32

    v2 v3  
    1313
    1414Alternatively, we could just replace the `markTestSkipped()` and `markTestIncomplete()` calls with `expectNotToPerformAssertions()` for the timebeing.
     15
     16A [https://core.trac.wordpress.org/changeset/54058 somewhat related changeset], that could serve as a precedent, mentions:
     17
     18> The `@doesNotPerformAssertions` annotation **can be reconsidered in the future** when the tests are either removed as unnecessary or **updated to actually perform assertions related to their behavior**.
     19(my emphasis)
     20
     21In this case, the `@doesNotPerformAssertions` annotation isn't appropriate as we'd be conditionally marking a test as not performing assertions, so the method `expectNotToPerformAssertions()` makes more sense.