WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#60231 new defect (bug)

Replace constant ABSPATH . WPINC with BLOCKS_PATH in the require-dynamic-blocks.php

Reported by: vishalkakadiya Owned by:
Priority: normal Milestone: Awaiting Review
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Basically, we are already defining the BLOCKS_PATH constant in the wp-includes/blocks/index.php file which is loading the require-dynamic-blocks.php

So it is good practice to replace combination ABSPATH . WPINC constants with BLOCKS_PATH single constant in the require-dynamic-blocks.php file generated by tools/release/sync-stable-blocks.js file.

Attachments (1)

60231.diff​ (522 bytes ) - added by vishalkakadiya 3 years ago.
Patch file

Download all attachments as: .zip

Change History (5)

@vishalkakadiya
3 years ago

Patch file

#1 @vishalkakadiya
3 years ago

I have added a patch file to this issue. Thanks!

This ticket was mentioned in ​PR #5857 on ​WordPress/wordpress-develop by ​@vishalkakadiya.
3 years ago #2

​@mukesh27 commented on ​PR #5857:
3 years ago #3

Thanks @vishalkakadiya for the PR! Left one comment.

Could you please share steps how anyone test it?

#4 @mukesh27
3 years ago

  • Component General → Build/Test Tools
  • Version trunk
Note: See TracTickets for help on using tickets.