Revert usage of str_contains() in older bundled themes

[SergeyBiryukov]

Background: #58206.

In [55988], instances of false !== strpos( ... ) were replaced with str_contains() in core files, including the Twenty Twenty and Twenty Seventeen bundled themes.

As pointed out by @poena, the polyfill for str_contains() is only available in WordPress 5.9 or later, while Twenty Twenty supports WordPress 4.7 and PHP 5.2.4, where the use of str_contains() causes fatal errors. This applies to Twenty Seventeen too.

Full list of changes that should be reverted: [55988/trunk/src/wp-content/themes].

[SergeyBiryukov]

In 57275:

Twenty Seventeen: Revert usage of str_contains() in theme files.

The theme supports WordPress 4.7 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988].

Props poena.
See #60241.

[SergeyBiryukov]

In 57276:

Twenty Twenty: Revert usage of str_contains() in theme files.

The theme supports WordPress 4.7 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988], [57275].

Props poena.
See #60241.

[SergeyBiryukov]

In 57277:

Twenty Twenty-One: Revert usage of str_contains() in theme files.

The theme supports WordPress 5.3 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988], [57275], [57276].

Props poena.
Fixes #60241.

[sabernhardt]

Thanks. #58012 avoided changing to str_starts_with in bundled themes, but I apparently missed the switch to str_contains.

[poena]

@desrosj @onemaggie I think we need to release new versions of these themes, outside the normal release cycle, since the issue caused fatal errors.

[desrosj]

Thanks for catching and working on this all!

I agree, an out of cycle release makes sense. I'm going to work on that now!

[desrosj]

Reopening because if there are additional changes to these themes in trunk, it may make more sense to backport the changes and release from the 6.4 branch.

[desrosj]

In 57291:

Twenty Seventeen: Revert usage of str_contains() in theme files.

The theme supports WordPress 4.7 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988].

Merges [57275] to the 6.4 branch.

Props poena, SergeyBiryukov.
See #60241.

[desrosj]

In 57292:

Twenty Twenty: Revert usage of str_contains() in theme files.

The theme supports WordPress 4.7 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988], [57275].

Merges [57276] to the 6.4 branch.

Props poena, SergeyBiryukov.
See #60241.

[desrosj]

In 57293:

Twenty Twenty-One: Revert usage of str_contains() in theme files.

The theme supports WordPress 5.3 or later, while the polyfill for str_contains() only exists in WordPress 5.9 or later.

Follow-up to [55988], [57275], [57276].

Merges [57277] to the 6.4 branch.

Props poena, SergeyBiryukov.
Fixes #60241.

[jorbin]

Adjusting the version since the changes are being backported.

[desrosj]

These themes have been released to the world: ​https://make.wordpress.org/core/2024/01/16/twenty-twenty-one-twenty-twenty-and-twenty-seventeen-updates-now-available/.

[sabernhardt]

I added a link on the ticket number in the ​Twenty Seventeen changelog and mentioned the earlier change from #58206 under version 3.3.

However, I cannot edit the other two changelogs (fixing the 60241 link and mentioning the change two versions earlier).