Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#60245 closed defect (bug) (fixed)

textdomain is missing in inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme

Reported by: shailu25's profile shailu25 Owned by: audrasjb's profile audrasjb
Milestone: 6.5 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

textdomain is missing in inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme

EX:

1.Twenty Sixteen: Line 57 in inc/block-patterns.php

<h1 style="font-size:55px">' . esc_html__( 'Twenty Sixteen' ) . '</h1>

2. Twenty Seventeen: Line 134 in inc/block-patterns.php

<a href="#">' . __( 'See Case Study' ) . ' →</a></p>

Attachments (3)

60245.patch (1.7 KB) - added by shailu25 3 months ago.
Patch added
60245.2.patch (2.8 KB) - added by shailu25 3 months ago.
Patch Updated
60245.3.patch (1.1 KB) - added by sabernhardt 3 months ago.
removing tab character from twentytwentyfour text domain

Download all attachments as: .zip

Change History (12)

@shailu25
3 months ago

Patch added

#1 @shailu25
3 months ago

  • Keywords has-patch added

#2 @sabernhardt
3 months ago

  • Milestone changed from Awaiting Review to 6.5
  • Severity changed from trivial to normal
  • Version set to 5.6

Thanks for the report and patch!

The commits that introduced these block patterns were [49583] for Twenty Sixteen and [49584] for Twenty Seventeen.

I also found one more string missing the textdomain in Twenty Twenty-Four's 'hidden-portfolio-hero' pattern (PR 437 / [56716]).

@shailu25
3 months ago

Patch Updated

#3 @shailu25
3 months ago

Updated Patch as per mentioned in above comment

I have added missing textdomain in /inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme & /patterns/hidden-portfolio-hero.php in twenty twenty four

#4 @audrasjb
3 months ago

Thanks for the ticket and patch!
Self assigning for commit consideration.

#5 @audrasjb
3 months ago

  • Keywords commit added

#6 @audrasjb
3 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 57281:

Bundled Themes: Add missing text domain to various block patterns.

This changeset adds missing text domain to block patterns in Twenty Sixteen, Twenty Seventeen and Twenty Twenty-Four.

Follow-up to [49583] (Twenty Sixteen), [49584] (Twenty Seventeen) and [56716] (Twenty Twenty-Four.)

Props shailu25, sabernhardt.
Fixes #60245.

#7 @audrasjb
3 months ago

In 57282:

Twenty Seventeen: Fix wrong text-domain introduced in [57281].

Follow-up to [57281].

Unprops audrasjb.
See #60245.

@sabernhardt
3 months ago

removing tab character from twentytwentyfour text domain

#8 @sabernhardt
3 months ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

[57281] added a tab character inside the 'twentytwentyfour' text domain.

#9 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57304:

Twenty Twenty-Four: Remove extra tab character inside the text domain.

Follow-up to [57281].

Props sabernhardt.
Fixes #60245.

Note: See TracTickets for help on using tickets.