textdomain is missing in inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme

[shailu25]

textdomain is missing in inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme

EX:

1.Twenty Sixteen: Line 57 in inc/block-patterns.php

<h1 style="font-size:55px">' . esc_html__( 'Twenty Sixteen' ) . '</h1>

2. Twenty Seventeen: Line 134 in inc/block-patterns.php

<a href="#">' . __( 'See Case Study' ) . ' →</a></p>

[shailu25]

Patch added

[sabernhardt]

Thanks for the report and patch!

The commits that introduced these block patterns were [49583] for Twenty Sixteen and [49584] for Twenty Seventeen.

I also found one more string missing the textdomain in Twenty Twenty-Four's 'hidden-portfolio-hero' pattern (​PR 437 / [56716]).

[shailu25]

Patch Updated

[shailu25]

Updated Patch as per mentioned in above comment

I have added missing textdomain in /inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme & /patterns/hidden-portfolio-hero.php in twenty twenty four

[audrasjb]

Thanks for the ticket and patch!
Self assigning for commit consideration.

[audrasjb]

In 57281:

Bundled Themes: Add missing text domain to various block patterns.

This changeset adds missing text domain to block patterns in Twenty Sixteen, Twenty Seventeen and Twenty Twenty-Four.

Follow-up to [49583] (Twenty Sixteen), [49584] (Twenty Seventeen) and [56716] (Twenty Twenty-Four.)

Props shailu25, sabernhardt.
Fixes #60245.

[audrasjb]

In 57282:

Twenty Seventeen: Fix wrong text-domain introduced in [57281].

Follow-up to [57281].

Unprops audrasjb.
See #60245.

[sabernhardt]

removing tab character from twentytwentyfour text domain

[sabernhardt]

[57281] added a tab character inside the 'twentytwentyfour' text domain.

[SergeyBiryukov]

In 57304:

Twenty Twenty-Four: Remove extra tab character inside the text domain.

Follow-up to [57281].

Props sabernhardt.
Fixes #60245.