![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 3 years ago
Closed 3 years ago
#60245 closed defect (bug) (fixed)
textdomain is missing in inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme
| Reported by: | shailu25 | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.5 |
| Component: | Bundled Theme | Version: | 5.6 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
textdomain is missing in inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme
EX:
1.Twenty Sixteen: Line 57 in inc/block-patterns.php
<h1 style="font-size:55px">' . esc_html__( 'Twenty Sixteen' ) . '</h1>
2. Twenty Seventeen: Line 134 in inc/block-patterns.php
<a href="#">' . __( 'See Case Study' ) . ' →</a></p>
Attachments (3)
Change History (12)
#2
@
3 years ago
- Milestone Awaiting Review → 6.5
- Severity trivial → normal
- Version → 5.6
Thanks for the report and patch!
The commits that introduced these block patterns were [49583] for Twenty Sixteen and [49584] for Twenty Seventeen.
I also found one more string missing the textdomain in Twenty Twenty-Four's 'hidden-portfolio-hero' pattern (PR 437 / [56716]).
#3
@
3 years ago
Updated Patch as per mentioned in above comment
I have added missing textdomain in /inc/block-patterns.php in Twenty Sixteen & Twenty Seventeen Theme & /patterns/hidden-portfolio-hero.php in twenty twenty four
Note:
See TracTickets
for help on using tickets.
Patch added