#60279 closed task (blessed) (fixed)
Composer: update to PHP_CodeSniffer 3.8.1
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | 6.5 |
Component: | Build/Test Tools | Keywords: | has-patch add-to-field-guide |
Focuses: | coding-standards | Cc: |
Description
PHPCS has seen two new releases since the update to WPCS 3.0, with especially the 3.8.0 version containing a huge number of improvements.
Refs:
- https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.0
- https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.8.1
Also note that PHPCSUtils and PHPCSExtra, both dependencies of WPCS 3.0+, are not locked down, meaning that the version used by contributors _may_ not always be the same. I don't expect any significant problems with that, but we may want to consider locking them down anyway.
Both projects have had releases since the original update to WPCS 3.0.
Refs:
- https://github.com/PHPCSStandards/PHPCSUtils/releases/tag/1.0.9
- https://github.com/PHPCSStandards/PHPCSExtra/releases/tag/1.2.1
Previous: #59161
Change History (7)
This ticket was mentioned in PR #5890 on WordPress/wordpress-develop by @jrf.
13 months ago
#1
- Keywords has-patch added
@SergeyBiryukov commented on PR #5890:
13 months ago
#5
Note: See
TracTickets for help on using
tickets.
### Composer: update PHPCS to v 3.8.1
PHPCS has seen two new releases since the update to WPCS 3.0, with especially the 3.8.0 version containing a huge number of improvements.
Refs:
Also note that PHPCSUtils and PHPCSExtra, both dependencies of WPCS 3.0+, are not locked down, meaning that the version used by contributors _may_ not always be the same. I don't expect any significant problems with that, but we may want to consider locking them down anyway.
Both projects have had releases since the original update to WPCS 3.0.
Refs:
Previous: Trac 59161
### CS: fix up assignment operator alignment
These keep sneaking in, what with them being warnings ;-)
### QA: use strict in_array() calls
.. to prevent type juggling causing incorrect results.
Trac ticket: https://core.trac.wordpress.org/ticket/60279