Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 4 months ago

#60279 closed task (blessed) (fixed)

Composer: update to PHP_CodeSniffer 3.8.1

Reported by: jrf's profile jrf Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: Build/Test Tools Keywords: has-patch add-to-field-guide
Focuses: coding-standards Cc:

Description

PHPCS has seen two new releases since the update to WPCS 3.0, with especially the 3.8.0 version containing a huge number of improvements.

Refs:

Also note that PHPCSUtils and PHPCSExtra, both dependencies of WPCS 3.0+, are not locked down, meaning that the version used by contributors _may_ not always be the same. I don't expect any significant problems with that, but we may want to consider locking them down anyway.
Both projects have had releases since the original update to WPCS 3.0.

Refs:

Previous: #59161

Change History (7)

This ticket was mentioned in PR #5890 on WordPress/wordpress-develop by @jrf.


5 months ago
#1

  • Keywords has-patch added

### Composer: update PHPCS to v 3.8.1

PHPCS has seen two new releases since the update to WPCS 3.0, with especially the 3.8.0 version containing a huge number of improvements.

Refs:

Also note that PHPCSUtils and PHPCSExtra, both dependencies of WPCS 3.0+, are not locked down, meaning that the version used by contributors _may_ not always be the same. I don't expect any significant problems with that, but we may want to consider locking them down anyway.
Both projects have had releases since the original update to WPCS 3.0.

Refs:

Previous: Trac 59161

### CS: fix up assignment operator alignment

These keep sneaking in, what with them being warnings ;-)

### QA: use strict in_array() calls

.. to prevent type juggling causing incorrect results.

Trac ticket: https://core.trac.wordpress.org/ticket/60279

#2 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#3 @SergeyBiryukov
5 months ago

In 57372:

Coding Standards: Use strict type check for in_array() in get_hooked_block_markup().

This aims to prevent type juggling causing incorrect results.

Follow-up to [57157].

Props jrf.
See #60279.

#4 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 57378:

Coding Standards: Update PHPCS to version 3.8.1.

PHPCS has seen two new releases since the update to WPCS 3.0, with especially the 3.8.0 version containing a huge number of improvements.

References:

Follow-up to [56695].

Props jrf, swissspidy.
Fixes #60279.

@SergeyBiryukov commented on PR #5890:


5 months ago
#5

Thanks for the PR! Merged in r57365, r57372, and r57378.

@jrf commented on PR #5890:


5 months ago
#6

Thanks @SergeyBiryukov !

#7 @stevenlinx
4 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.