![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#60292 closed defect (bug) (fixed)
Layout: backport fix to ensure blocks without layout support do not receive layout classnames
| Reported by: | andrewserong | Owned by: | isabel_brison |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.5 |
| Component: | Editor | Version: | 6.5 |
| Severity: | normal | Keywords: | gutenberg-merge has-patch has-unit-tests |
| Cc: | Focuses: |
Description
This ticket is to track backporting a fix from the Gutenberg repo, which landed in https://github.com/WordPress/gutenberg/pull/56187 :
Prevent layout classnames from being output on blocks where there is no layout support and child layout classnames are not being output. An example is a paragraph that is a child of a group block, and that has selfStretch set to fit. In this case, no layout classnames should be added to the paragraph block, but prior to https://github.com/WordPress/gutenberg/pull/56187 they were being added unexpectedly.
Change History (4)
This ticket was mentioned in PR #5900 on WordPress/wordpress-develop by @andrewserong.
2 years ago
#1
- Keywords has-patch has-unit-tests added
@isabel_brison commented on PR #5900:
2 years ago
#3
Committed in r57328.
@andrewserong commented on PR #5900:
2 years ago
#4
Thanks for reviewing and committing!
Backport changes from the Gutenberg plugin in: https://github.com/WordPress/gutenberg/pull/56187
Prevent layout classnames from being output on blocks where there is no layout support _and_ child layout classnames are not being output. An example is a paragraph that is a child of a group block, and that has
selfStretchset tofit. In this case, no layout classnames should be added to the paragraph block, but prior to https://github.com/WordPress/gutenberg/pull/56187 they were being added unexpectedly.This PR also adds a test to cover the fix. For further context and sample test markup, see the PR description of https://github.com/WordPress/gutenberg/pull/56187
Trac ticket: https://core.trac.wordpress.org/ticket/60292