WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#60294 closed defect (bug) (fixed)

Block custom CSS: Backport updates to PHPUnit tests

Reported by: wildworks Owned by: youknowriad
Priority: normal Milestone: 6.5
Component: Editor Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description

Backports changes to PHPUnit test made in the Gutenberg plugin with: ​https://github.com/WordPress/gutenberg/pull/53602

In #59499, the fix itself was backported to the core. But it lacked a backport of PHPUnit tests to guarantee its fix.

Change History (5)

This ticket was mentioned in ​PR #5902 on ​WordPress/wordpress-develop by ​@wildworks.
3 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/60294

#2 @youknowriad
3 years ago

  • Owner set to youknowriad
  • Resolution → fixed
  • Status new → closed

In 57333:

Editor: Update the ThemeJson unit test to cover custom CSS feature.

In #59499 a fix have been shipped to theme.json custom CSS
when applied to blocks with multiple CSS selectors.
This commit covers that fix with a unit test.

Props wildworks.
Fixes #60294.

#4 @kebbet
3 years ago

Please milestone the ticket to 6.5 @youknowriad, thanks!

#5 @youknowriad
3 years ago

  • Milestone Awaiting Review → 6.5
Note: See TracTickets for help on using tickets.