Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#60307 closed defect (bug) (fixed)

HTML API: Cleanup tests and list of void elements.

Reported by: dmsnell's profile dmsnell Owned by: dmsnell's profile dmsnell
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: HTML API Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

This patch adds newly supported elements to tests that should have
been updated in recent PRs, but which were merged without that. Those
PRs removed failing tests showing that the elements were unsupported,
but did not add the elements to the list of supported ones.

It also removes some elements from the special-exclusion list of
unsupported IN BODY elements. These did not present in failing tests
because earlier conditions in the switch structure caught the tags
before hitting the default block.

Finally it adds some missing elements to the list of void elements.
These elements are not listed as void in the HTML specification because
they are deprecated. However, they are treated as void for the sake of
HTML serialization and the parsing rules indicate that they behave as
void elements, so it's safe to list them within the HTML API as void.

Change History (5)

This ticket was mentioned in PR #5913 on WordPress/wordpress-develop by @dmsnell.


3 months ago
#1

  • Keywords has-unit-tests added

Trac ticket: Core-60307

This patch adds newly supported elements to tests that should have been updated in recent PRs, but which were merged without that. Those PRs removed failing tests showing that the elements were unsupported, but did not add the elements to the list of supported ones.

It also removes some elements from the special-exclusion list of unsupported IN BODY elements. These did not present in failing tests because earlier conditions in the switch structure caught the tags before hitting the default block.

Finally it adds some missing elements to the list of void elements. These elements are not listed as void in the HTML specification because they are deprecated. However, they are treated as void for the sake of HTML serialization and the parsing rules indicate that they behave as void elements, so it's safe to list them within the HTML API as void.

Trac ticket:

#2 @dmsnell
3 months ago

  • Owner set to dmsnell
  • Resolution set to fixed
  • Status changed from new to closed

In 57319:

HTML API: Cleanup tests and list of void elements.

This patch adds newly supported elements to tests that should have been updated
in recent PRs, but which were merged without that. Those PRs removed failing
tests showing that the elements were unsupported, but did not add the elements
to the list of supported ones.

It also removes some elements from the special-exclusion list of unsupported IN
BODY elements. These did not present in failing tests because earlier
conditions in the switch structure caught the tags before hitting the default
block.

Finally it adds some missing elements to the list of void elements. These
elements are not listed as void in the HTML specification because they are
deprecated. However, they are treated as void for the sake of HTML
serialization and the parsing rules indicate that they behave as void elements,
so it's safe to list them within the HTML API as void.

Developed in WordPress/wordpress-develop#5913

Fixes #60307

@dmsnell commented on PR #5913:


3 months ago
#3

Merged in edcc85c31ca676d04e61862b5f23ce5fa278d31f
https://core.trac.wordpress.org/changeset/57319

#4 @kebbet
3 months ago

Please milestone the ticket to 6.5 @dmsnell, thanks!

#5 @dmsnell
3 months ago

  • Milestone changed from Awaiting Review to 6.5

thanks @kebbet - I've set the milestone to 6.5

Note: See TracTickets for help on using tickets.