Make WordPress Core

Opened 3 months ago

Closed 8 weeks ago

#60323 closed defect (bug) (fixed)

Add missing full stop

Reported by: hardik2221's profile hardik2221 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch commit
Focuses: docs, coding-standards Cc:

Description

When I review wp-includes/class-wp-comment-query.php this file only one place which have missing full stop.

Attachments (2)

60323.patch (624 bytes) - added by hardik2221 3 months ago.
60323.2.patch (1.8 KB) - added by shailu25 2 months ago.
Updated Patch

Download all attachments as: .zip

Change History (9)

@hardik2221
3 months ago

#1 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 6.5

#2 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57342:

Docs: Add missing full stop in WP_Comment_Query::parse_query() DocBlock.

Props hardik2221.
Fixes #60323.

#3 @sabernhardt
3 months ago

The WP_Network_Query and WP_Term_Query classes likewise do not have a full stop at the end of their parse_query parameter documentation.

Besides adding the periods, would it be worth including either "for accepted arguments" or "for information on accepted arguments"?

WP_Comment_Query::parse_query(), which now has the period

WP_Network_Query::parse_query()

WP_Term_Query::parse_query()

#4 @SergeyBiryukov
3 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@shailu25
2 months ago

Updated Patch

#5 @shailu25
2 months ago

Updated Patch as per suggested in above comment

#6 @swissspidy
8 weeks ago

  • Keywords commit added

#7 @swissspidy
8 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57719:

Docs: Improve wording and add missing full stops in a few docblocks.

Props shailu25, sabernhardt.
Fixes #60323.

Note: See TracTickets for help on using tickets.