Opened 9 months ago
Closed 9 months ago
#60325 closed defect (bug) (fixed)
Twenty Twenty-Four: system-serif slug type-o
Reported by: | RavanH | Owned by: | swissspidy |
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Description
When trying the set, for example, the global headings font family to System Serif, the global style setting will be converted to style rule font-family: var(--wp--preset--font-family--system-Serif);
(notice the upper case S) referencing a non-existent root variable.
Testing Instructions
- Go to global style settings and change the Headings font face to System Serif.
- Save styles.
- Verify any headings on the front end: they will be using the browser default, not the root
--wp--preset--font-family--system-serif
(notice the lower case S) value.
Change History (8)
This ticket was mentioned in PR #5933 on WordPress/wordpress-develop by RavanH.
9 months ago
#1
- Keywords has-patch added
#2
@
9 months ago
- Component changed from Themes to Bundled Theme
- Milestone changed from Awaiting Review to 6.5
#3
@
9 months ago
This change makes sense and it also makes theme.json consistent with the style variations. Thanks for the patch
#4
@
9 months ago
Nice catch! I followed your testing instructions and observed the issue as well. I agree, your patch seems effective and well-done.
@mukesh27 commented on PR #5933:
9 months ago
#6
Nice catch @RavanH.
Note: See
TracTickets for help on using
tickets.
Replaces upper case S in slug
system-Serif
by lower case s.Trac ticket: https://core.trac.wordpress.org/ticket/60325