Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#60325 closed defect (bug) (fixed)

Twenty Twenty-Four: system-serif slug type-o

Reported by: ravanh's profile RavanH Owned by: swissspidy's profile swissspidy
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Description

When trying the set, for example, the global headings font family to System Serif, the global style setting will be converted to style rule font-family: var(--wp--preset--font-family--system-Serif); (notice the upper case S) referencing a non-existent root variable.

Testing Instructions

  1. Go to global style settings and change the Headings font face to System Serif.
  2. Save styles.
  3. Verify any headings on the front end: they will be using the browser default, not the root --wp--preset--font-family--system-serif (notice the lower case S) value.

Change History (8)

This ticket was mentioned in PR #5933 on WordPress/wordpress-develop by RavanH.


3 months ago
#1

  • Keywords has-patch added

Replaces upper case S in slug system-Serif by lower case s.

Trac ticket: https://core.trac.wordpress.org/ticket/60325

#2 @poena
3 months ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from Awaiting Review to 6.5

#3 @onemaggie
3 months ago

This change makes sense and it also makes theme.json consistent with the style variations. Thanks for the patch

#4 @huzaifaalmesbah
3 months ago

Nice catch! I followed your testing instructions and observed the issue as well. I agree, your patch seems effective and well-done.

#5 @poena
3 months ago

  • Keywords commit added

@mukesh27 commented on PR #5933:


3 months ago
#6

Nice catch @RavanH.

#7 @mukesh27
3 months ago

  • Version trunk deleted

#8 @swissspidy
3 months ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 57351:

Twenty Twenty-Four: Change font family slug to lowercase.

Ensures referencing the correct CSS custom property.

Props RavanH, poena, onemaggie, huzaifaalmesbah, mukesh27.
Fixes #60325.

Note: See TracTickets for help on using tickets.