WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#6034 closed defect (bug) (fixed)

error class in wp-admin needs restyling

Reported by: technosailor Owned by: iammattthomas
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Immediate observation:

1) It doesn't fit the full width paradigm
2) the pink/red is harsh with the blues/oranges

Attachments (9)

6034.diff (520 bytes) - added by technosailor 6 years ago.
6034-2.diff (517 bytes) - added by iammattthomas 6 years ago.
Patch with HC colors
6034-2.2.diff (532 bytes) - added by iammattthomas 6 years ago.
Patch with HC colors
Picture 4.png (7.7 KB) - added by technosailor 6 years ago.
Is this really what we want?!
6034-3.diff (377 bytes) - added by iammattthomas 6 years ago.
Make links in error messages white
Error message Add User.png (30.8 KB) - added by mdawaffe 6 years ago.
add user error message
6034-4.diff (661 bytes) - added by iammattthomas 6 years ago.
6034-5.diff (1.2 KB) - added by iammattthomas 6 years ago.
Change error message colors
screenshot.png (34.9 KB) - added by iammattthomas 6 years ago.
New error and invalid highlighting colors

Download all attachments as: .zip

Change History (25)

comment:1 technosailor6 years ago

  • Owner changed from anonymous to technosailor

Patch attached. Suggested bg color used - based on recommendation from colorschemer online. I'm easy though if Happy Cog provided some other color for this sort of thing in their pallette.

technosailor6 years ago

comment:2 technosailor6 years ago

  • Keywords has-patch added

comment:3 ryan6 years ago

  • Owner changed from technosailor to iammattthomas

iammattthomas6 years ago

Patch with HC colors

iammattthomas6 years ago

Patch with HC colors

comment:4 iammattthomas6 years ago

  • Milestone changed from 2.6 to 2.5

Found a comp with error message styling specified. I've attached another patch with their colors specified.

comment:5 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7115]) Error class stlying from mt. fixes #6034

comment:6 technosailor6 years ago

Holy flip that's bright. I think I like my colors better. Way easier on the eyes. I'm assuming you reviewed the colors? :) Screenshot attached.

technosailor6 years ago

Is this really what we want?!

comment:7 ryan6 years ago

You certainly can't overlook it.

comment:8 iammattthomas6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I think that's the point with the color selection, but I'll forward this ticket to Happy Cog for their input. I'm sending a patch with the correct link color, though.

iammattthomas6 years ago

Make links in error messages white

comment:9 ryan6 years ago

(In [7117]) Fix link colors for error class. Props mt. see #6034

mdawaffe6 years ago

add user error message

comment:10 mdawaffe6 years ago

Error message Add User.png

Shows error message and .form-invalid highlights (pink rows).

How does the .form-invalid color look?

The error message is not full width. #ajax-resonse should probably have no padding or margins globally since it's an empty element on all pages 95% of the time. Also, the margins for .error are tuned for when it's at the top of the screen, which is not always the case.

[7103/trunk/wp-admin/wp-admin.css] is what I did for the recent post edit collision ajax messages that show up underneath the post box. (Here, #autosave is like #ajax-response.)

Note - we can rename the #ajax-response on the add users page to anything we want. It'll require a JS tweak is all.

comment:11 iammattthomas6 years ago

Sending patch that sets margins for .updated and .error inside .wrap; remove padding from .ajax-response; edit .tablenav margin to account for change to .ajax-response.

iammattthomas6 years ago

comment:12 ryan6 years ago

(In [7118]) More error class styling from mt. see #6034

iammattthomas6 years ago

Change error message colors

iammattthomas6 years ago

New error and invalid highlighting colors

comment:13 iammattthomas6 years ago

6034-5.diff changes error message colors to new ones provided by Happy Cog. It also changes the color of the invalid field highlighting, and adds a border on all form-table inputs and textareas so that border sizes are consistent with the new field highligting. (Screenshot)

comment:14 technosailor6 years ago

BEAUTIFUL! :)

comment:15 iammattthomas6 years ago

Definitely an improvement. :)

comment:16 ryan6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [7136]) Error class styling from mt. fixes #6034

Note: See TracTickets for help on using tickets.