WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#60343 closed defect (bug) (fixed)

Fix: Theme.json application of custom root selector for styles

Reported by: aaronrobertshaw's profile aaronrobertshaw Owned by: youknowriad's profile youknowriad
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: Editor Keywords: gutenberg-merge has-patch has-unit-tests
Focuses: Cc:

Description

This ticket tracks the backporting of PHP files for the following Gutenberg changes:

​https://github.com/WordPress/gutenberg/pull/58050

These changes fix the incorrect application of a custom root selector in theme.json.

Change History (5)

This ticket was mentioned in ​PR #5944 on ​WordPress/wordpress-develop by ​@aaronrobertshaw.
2 years ago #1

  • Keywords has-patch has-unit-tests added

Syncs the changes from ​https://github.com/WordPress/gutenberg/pull/58050 to core.

These changes fix the incorrect application of a custom root selector in theme.json.

To test:

npm run test:php -- --filter Tests_Theme_wpThemeJson

Trac ticket: https://core.trac.wordpress.org/ticket/60343

#2 @get_dave
2 years ago

I tested this PR and the unit test passed successfully

OK (139 tests, 403 assertions)

Also verified file changes mirror those originally made in the PR being synced from Gutenberg to Core.

@youknowriad I think this can be committed.

#3 @youknowriad
2 years ago

  • Milestone changed from Awaiting Review to 6.5

#4 @youknowriad
2 years ago

  • Owner set to youknowriad
  • Resolution set to fixed
  • Status changed from new to closed

In 57352:

Editor: Fix Theme.json application of custom root selector for styles.

Theme.json stylesheets attempting to use a custom root selector are generated with in correct styles.

Props aaronrobertshaw, get_dave, mukesh27.
Fixes #60343.

Note: See TracTickets for help on using tickets.