Make WordPress Core

Opened 6 months ago

Last modified 6 months ago

#60364 new defect (bug)

Incorrect argument type given on number_format

Reported by: krishneup's profile krishneup Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch
Focuses: Cc:

Description (last modified by sabernhardt)

Argument #1 ($num) must be of type float, string given in /var/www/src/wp-admin/includes/class-wp-debug-data.php:587

Change History (4)

#1 follow-up: @audrasjb
6 months ago

Hello, welcome to WordPress Core Trac and thank you for opening this ticket,

Could you please specify the exact function where the issue is located?
L587 doesn't correspond to your issue: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/class-wp-debug-data.php#L587

Thanks

#2 @krishneup
6 months ago

Sorry for the wrong line number.

here's the MR link - https://github.com/WordPress/wordpress-develop/pull/5960

#3 in reply to: ↑ 1 @krishneup
6 months ago

Replying to audrasjb:

Hello, welcome to WordPress Core Trac and thank you for opening this ticket,

Could you please specify the exact function where the issue is located?
L587 doesn't correspond to your issue: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/class-wp-debug-data.php#L587

Thanks

Now I understand why my PR wasn't linked here. I am sorry for troubling you, it seems my github account has a bug, which I probably need to report with Github support team.

These were my changes: https://ibb.co/59HWPjJ
Unfortunately, you may not able to see my MR.

#4 @sabernhardt
6 months ago

  • Description modified (diff)

The PR proposes to run floatval() within number_format() on line 585:
'value' => number_format( floatval( $max_file_uploads ) ),

  1. Should this test use number_format_i18n() instead of number_format()?
  2. Could it use (float) instead of floatval()?
  3. Would it be better to assign the type when setting the variable?
    $max_file_uploads = (float) ini_get( 'max_file_uploads' );

The test was added in [48535].

Note: See TracTickets for help on using tickets.