Make WordPress Core

Changes between Initial Version and Version 4 of Ticket #60364


Ignore:
Timestamp:
01/29/2024 07:59:37 AM (10 months ago)
Author:
sabernhardt
Comment:

The PR proposes to run floatval() within number_format() on line 585: 'value' => number_format( floatval( $max_file_uploads ) ),

  1. Should this test use number_format_i18n() instead of number_format()?
  2. Could it use (float) instead of floatval()?
  3. Would it be better to assign the type when setting the variable?
    $max_file_uploads = (float) ini_get( 'max_file_uploads' );

The test was added in [48535].

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #60364 – Description

    initial v4  
    1 Argument #1 ($num) must be of type float, string given in /var/www/src/wp-admin/includes/class-wp-debug-data.php:587
     1`Argument #1 ($num) must be of type float, string given in /var/www/src/wp-admin/includes/class-wp-debug-data.php:587`