WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#60387 closed task (blessed) (fixed)

Backport theme.json tests from Gutenberg

Reported by: ajlende Owned by: youknowriad
Priority: normal Milestone: 6.5
Component: Themes Version: 6.5
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description

Paired with ​https://github.com/WordPress/gutenberg/pull/58476.

Merges the changes from Core and Gutenberg for the following tests:

  1. wpThemeJson.php
  2. wpThemeJsonResolver.php
  3. wpThemeJsonSchema.php

Change History (7)

This ticket was mentioned in ​PR #5979 on ​WordPress/wordpress-develop by ​@ajlende.
3 years ago #1

  • Keywords has-patch has-unit-tests added

Merges the changes from Core and Gutenberg for the following tests:

  1. wpThemeJson.php
  2. wpThemeJsonResolver.php
  3. wpThemeJsonSchema.php

Paired with ​https://github.com/WordPress/gutenberg/pull/58476.

Trac ticket: https://core.trac.wordpress.org/ticket/60387

​@get_dave commented on ​PR #5979:
3 years ago #2

@youknowriad this has a ✅

​@youknowriad commented on ​PR #5979:
3 years ago #3

Can we get this rebased please. Thank you.

​@scruffian commented on ​PR #5979:
3 years ago #4

It would be great if we can bring this in to trunk so we can keep things synced up

#5 @youknowriad
3 years ago

  • Owner set to youknowriad
  • Resolution → fixed
  • Status new → closed

In 57662:

Tests: Synchronize Theme.JSON unit test between Core and Gutenberg.

Merges the changes from Core and Gutenberg for the following tests:

  • WP_REST_Global_Styles_Controller_Test
  • Tests_Theme_wpThemeJsonResolver
  • Tests_Theme_wpThemeJsonSchema
  • Tests_Theme_wpThemeJson

This will help ensure the stability of the theme.json style generation.

Props ajlende, scruffian, aaronrobertshaw, get_dave, youknowriad.
Fixes #60387.

#6 @youknowriad
3 years ago

  • Milestone Awaiting Review → 6.5
  • Type enhancement → task (blessed)
Note: See TracTickets for help on using tickets.