Make WordPress Core

Opened 6 months ago

Last modified 2 weeks ago

#60389 new defect (bug)

PHP unit test for links_add_base_url

Reported by: pbearne's profile pbearne Owned by:
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests changes-requested
Focuses: Cc:

Description


Change History (4)

This ticket was mentioned in PR #5980 on WordPress/wordpress-develop by @pbearne.


6 months ago
#1

  • Keywords has-patch has-unit-tests added

A new PHPUnit test class, Tests_formatting_linksAddBaseUrl, has been introduced to increase the test coverage for the links_add_base_url function. The class includes multiple test scenarios, examining different combinations of attributes to verify the correct functioning of the function.

#2 @jorbin
4 months ago

  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to 6.6

Left a suggestion for additional test cases. PHPCS also needs a bit of attention.

#3 @rajinsharwar
3 months ago

Added some PHPCS changes, and also added a couple of more cases for sftp, and mailto.

#4 @desrosj
2 weeks ago

  • Milestone changed from 6.6 to 6.7

I'm going to punt this to 6.7. If a committer has time to review and commit this before 6.6 then feel free, but backporting is unlikely at this point anyway.

Note: See TracTickets for help on using tickets.