WordPress.org
Get WordPress

Make WordPress Core

Opened 15 months ago

Closed 7 months ago

Last modified 7 months ago

#60389 closed defect (bug) (fixed)

PHP unit test for links_add_base_url

Reported by: pbearne's profile pbearne Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests commit
Focuses: Cc:

Description


Change History (9)

This ticket was mentioned in ​PR #5980 on ​WordPress/wordpress-develop by ​@pbearne.
15 months ago #1

  • Keywords has-patch has-unit-tests added

A new PHPUnit test class, Tests_formatting_linksAddBaseUrl, has been introduced to increase the test coverage for the links_add_base_url function. The class includes multiple test scenarios, examining different combinations of attributes to verify the correct functioning of the function.

#2 @jorbin
13 months ago

  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to 6.6

Left a suggestion for additional test cases. PHPCS also needs a bit of attention.

#3 @rajinsharwar
12 months ago

Added some PHPCS changes, and also added a couple of more cases for sftp, and mailto.

#4 @desrosj
10 months ago

  • Milestone changed from 6.6 to 6.7

I'm going to punt this to 6.7. If a committer has time to review and commit this before 6.6 then feel free, but backporting is unlikely at this point anyway.

This ticket was mentioned in ​Slack in #core by chaion07. ​View the logs.
7 months ago

​@pbearne commented on ​PR #5980:
7 months ago #6

@pbearne Needs to fix the PHPCS fix.

fixed

#7 @ironprogrammer
7 months ago

  • Keywords commit added; changes-requested removed

As the requested changes have been addressed and ​PR approved, I'm updating for commit consideration.

#8 @peterwilsoncc
7 months ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 59162:

Tests/Build Tools: Introduce tests for links_add_base_url().

Props pbearne, rajinsharwar, jorbin, mukesh27, aristath, desrosj, ironprogrammer.
Fixes #60389.

Note: See TracTickets for help on using tickets.