WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#60401 closed defect (bug) (fixed)

Use $length in rand_long_str() documentation

Reported by: harsh175 Owned by: SergeyBiryukov
Priority: normal Milestone: 6.5
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

When I review this file tests/phpunit/includes/utils.php then I find a parameter description variable changes $len to $length.

Attachments (1)

60401.patch​ (487 bytes ) - added by harsh175 3 years ago.

Download all attachments as: .zip

Change History (4)

@harsh175
3 years ago

#1 @sabernhardt
2 years ago

  • Component General → Build/Test Tools
  • Summary Improve inline document → Use $length in rand_long_str() documentation

Thanks for the report and patch!

[50265] added that documentation. The variable name was rather confusing because the rand_str() function uses $len and rand_long_str() uses $length.

#2 @SergeyBiryukov
2 years ago

  • Milestone Awaiting Review → 6.5

#3 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 57749:

Build/Test Tools: Use a consistent parameter name between rand_str() and rand_long_str().

Follow-up to [36272], [50265].

Props harsh175, sabernhardt.
Fixes #60401.

Note: See TracTickets for help on using tickets.