#60410 closed enhancement (fixed)
TT4: Wrap Navigation block in Row within the header.html template part
Reported by: | tomjcafferkey | Owned by: | swissspidy |
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | 6.5 |
Component: | Bundled Theme | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Now that the Block Hooks API has been released as part of WordPress 6.4 3PDs may want to insert their own blocks into the header of the TT4 theme, specifically after the Navigation block. This currently causes problems because the Navigation block and it's siblings are treated as flex items due to its parent being a Row block.
Change History (8)
This ticket was mentioned in PR #6001 on WordPress/wordpress-develop by @tomjcafferkey.
8 months ago
#1
- Keywords has-patch added; needs-patch removed
#3
@
8 months ago
I have tested this on WordPress 6.4.3 on MacOS with Safari, Firefox, Chrome,
with different browser widths and different type of menus (short, long, links only, varied blocks like search, login/out, site logo.)
I have only tested for regressions in the layout and I do not see any.
I did not test block hooks with the new design.
This ticket was mentioned in Slack in #core by chaion07. View the logs.
8 months ago
@swissspidy commented on PR #6001:
8 months ago
#8
Committed in https://core.trac.wordpress.org/changeset/57621
Now that the Block Hooks API has been released as part of WordPress 6.4 3PDs may want to insert their own blocks into the header, specifically after the Navigation block. This currently causes problems because the Navigation block and it's siblings are treated as flex items due to its parent being a Row block.
This PR wraps the Navigation block within a Row block of its own. By default the behaviour of the header should remain the same and introduce no regressions but this now means plugins are able to use the Block Hooks API to automatically insert their own blocks using the Navigation as an anchor block without them being treated as flex items (e.g. Mini Cart or My Account blocks)
Trac ticket: https://core.trac.wordpress.org/ticket/60410#ticket
## Testing instructions