Make WordPress Core

Opened 10 months ago

Last modified 6 months ago

#60430 new enhancement

Spell enqueueing or enqueuing consistently

Reported by: shailu25's profile shailu25 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: trivial Version:
Component: General Keywords: has-patch 2nd-opinion
Focuses: docs Cc:

Description

Small Typo corrections in below files (Inline Documents)

  • In wp-includes/widgets/class-wp-widget-custom-html.php Line no 58
  • In wp-includes/script-loader.php line no 2430
  • In wp-includes/widgets/class-wp-widget-text.php line no 47
enqueueing

it should be

enqueuing

Attachments (1)

60430.patch (1.7 KB) - added by shailu25 10 months ago.
Patch Added

Download all attachments as: .zip

Change History (7)

@shailu25
10 months ago

Patch Added

#1 @shailu25
10 months ago

  • Keywords has-patch added

#2 @sabernhardt
9 months ago

  • Summary changed from Typo corrections in some files to Spell enqueuing consistently

According to Wiktionary and WordHippo, both forms are acceptable. Keeping them consistent would be good, and Core uses "enqueuing" in 7 of the 10 instances. I would prefer that (as it is in the patch) for fewer changes.

Also note that titles in the Block Editor Handbook and Learn WordPress have the extra E, but those are not consistent throughout.

#3 @sabernhardt
6 months ago

  • Milestone changed from Awaiting Review to 6.6

Adding to a milestone for consideration. This is probably more of an enhancement than a bugfix, but it's documentation.

  • [40631] added the _register_one method for the Text widget
  • [41376] added the _register_one method for the Custom HTML widget
  • [44164] added wp_common_block_scripts_and_styles() in the script-loader

#4 @hellofromTonya
6 months ago

  • Keywords 2nd-opinion added
  • Milestone changed from 6.6 to Awaiting Review
  • Summary changed from Spell enqueuing consistently to Spell enqueuing or enqueuing consistently
  • Type changed from defect (bug) to enhancement

Hello @shailu25,

I think this is a great idea to explore standardizing on either enqueueing or enqueuing for consistency.

As @sabernhardt noted, both forms are valid, are used in Core and Gutenberg codebases, are found in the handbooks, Developer Blog, Learn, etc.

As both forms are widely used, discussion and consensus are needed first to determine which form to use. That'll take time, more time than is remaining in 6.6.

To help this ticket move forward, I've adjusted it to be an enhancement and changed the title. Moving it back to Awaiting Review until there's consensus on which form to use.

Suggestion / Tip:
Change the description to better reflect the proposal in a way that gives contributors an understanding of what is being asked of them. For example, to consider which version of "enqueueing" or "enqueuing" should be adopted, i.e. rather than positioning the ticket to a decision that only "enqueuing" is the way to go.

#5 @sabernhardt
6 months ago

  • Summary changed from Spell enqueuing or enqueuing consistently to Spell enqueueing or enqueuing consistently

#6 @peterwilsoncc
6 months ago

My suggestion is to use enqueueing as it matches the enqueue in the various function names. Any standard is better than none so the actual spelling that's chosen isn't a hill I'm willing to die on.

Note: See TracTickets for help on using tickets.