#60453 closed defect (bug) (fixed)
Block Styles: Fix block style variation selector generation
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | 6.5 |
Component: | Editor | Keywords: | gutenberg-merge has-patch has-unit-tests |
Focuses: | Cc: |
Description
This ticket tracks the backporting of PHP files for the following Gutenberg changes:
https://github.com/WordPress/gutenberg/pull/58051
These changes fix the generation of selectors for block style variations which could previously invalid CSS selectors e.g. .is-style-darkp
instead of p.is-style-dark
if the block with the variation used an element tag as it's base selector.
Change History (5)
This ticket was mentioned in PR #6053 on WordPress/wordpress-develop by @aaronrobertshaw.
14 months ago
#1
- Keywords has-patch has-unit-tests added
@youknowriad commented on PR #6053:
14 months ago
#2
Thanks for the comprehensive tests.
#3
@
14 months ago
- Owner set to youknowriad
- Resolution set to fixed
- Status changed from new to closed
In 57547:
@youknowriad commented on PR #6053:
14 months ago
#5
Note: See
TracTickets for help on using
tickets.
Syncs the changes from https://github.com/WordPress/gutenberg/pull/58051.
These changes fix the generation of selectors for block style variations. Previously, an incorrect CSS selector could be generated if the block's base selector used an element tag etc.
To test:
Run:
npm run test:php -- --filter Tests_Theme_wpThemeJson
If you want to go further and test manually:
is-style-dark
is appended to thep
tag rather than prefixing itTrac ticket: https://core.trac.wordpress.org/ticket/60453