Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 3 months ago

#60456 closed enhancement (fixed)

Pattern overrides: Update overrides attribute data structure and rename it to content

Reported by: talldanwp's profile talldanwp Owned by: youknowriad's profile youknowriad
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: Editor Keywords: has-patch add-to-field-guide
Focuses: Cc:

Description

In the Gutenberg PR #58596, some changes were made to the data structure of the pattern overrides stored in the pattern block and consequently passed to the core/pattern-overrides block binding handler. Read there for more information on the reasoning.

Some of these changes need to be backported to WordPress core, so I'm creating this ticket for that change.

Change History (6)

This ticket was mentioned in PR #6055 on WordPress/wordpress-develop by @talldanwp.


4 months ago
#1

  • Keywords has-patch added

Backports the changes from https://github.com/WordPress/gutenberg/pull/58596.

The gutenberg PR changes the data structure of the overrides data to allow it to be more flexible for future features.

Trac ticket: [](https://core.trac.wordpress.org/ticket/60456)

@gziolo commented on PR #6055:


4 months ago
#2

@talldan, when you are done with all the backports, it would be great to add some basic PHPUnit tests covering how Pattern Overrides work with block bindings. It could be on the _block_bindings_pattern_overrides_get_value level to start with. However, more useful would be to have some integration test that runs do_blocks( '' ) (I had the old format in my local instance).

#3 @youknowriad
4 months ago

  • Owner set to youknowriad
  • Resolution set to fixed
  • Status changed from new to closed

In 57585:

Editor: Update pattern overrides attribute format.

Updates the pattern block's overrides attribute data structure and renames it to content.
This new format should prove more flexible for the future.

Props talldanwp, gziolo.
Fixes #60456.

#5 @hellofromTonya
4 months ago

#60454 was marked as a duplicate.

#6 @stevenlinx
3 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.