Make WordPress Core

Opened 2 years ago

Closed 20 months ago

#60462 closed enhancement (duplicate)

Twenty Twenty: Cover template overflows browser bar on mobile

Reported by: twiddler's profile twiddler Owned by:
Milestone: Priority: normal
Severity: trivial Version:
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: css Cc:

Description

Hey there!

Twenty Twenty's cover template fills the whole background with the article image. This works as expected on desktop. On mobile however, some content gets covered by the browser bar.

Replacing vh with dvh fixes that:

.screen-height {
   min-height: 100dvh;
}

Attachments (1)

60462.diff (1.2 KB) - added by twiddler 2 years ago.

Download all attachments as: .zip

Change History (10)

@twiddler
2 years ago

This ticket was mentioned in PR #6062 on WordPress/wordpress-develop by twiddler.


2 years ago
#1

  • Keywords has-patch added

Hey there! :wave:

Twenty Twenty's cover template fills the whole background with the article image. This works as expected on desktop. On mobile however, some content gets covered by the browser bar.

Replacing vh with dvh fixes that:

.screen-height {
   min-height: 100dvh;
}

Trac ticket: https://core.trac.wordpress.org/ticket/60462

#2 @sabernhardt
2 years ago

  • Component changed from Themes to Bundled Theme
  • Focuses css added; ui removed
  • Keywords changes-requested removed
  • Version trunk deleted

#3 @karmatosed
2 years ago

  • Milestone changed from Awaiting Review to Future Release

#4 @karmatosed
22 months ago

  • Keywords needs-testing added

It would be great to get some testing on this to ensure we discover if this is still an issue and if we want to progress.

#5 @poena
21 months ago

I am able to reproduce the issue on using the WordPress Playground. The arrow is not visible.

But I have not been able to test the PR. I am trying to test it from my mobile using WordPress Playground, since I can not reproduce the issue locally using the browser tools.
I am not sure if there is a problem because the tests failed, or if there is a problem with Playground itself.

#6 follow-up: @sabernhardt
20 months ago

Is this the same issue as #48837?

#7 in reply to: ↑ 6 @twiddler
20 months ago

Replying to sabernhardt:

Is this the same issue as #48837?

I think so, yes.

#8 @sabernhardt
20 months ago

  • Milestone Future Release deleted

Thanks! I'll close this as a duplicate and the discussion can continue on the other ticket.

#9 @sabernhardt
20 months ago

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #48837.

Note: See TracTickets for help on using tickets.