Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#60466 closed enhancement (fixed)

Introduce a contextual help tab for plugin dependencies

Reported by: desrosj Owned by: costdev
Priority: normal Milestone: 6.7
Component: Help/About Version:
Severity: normal Keywords: has-patch needs-copy-review
Cc: Focuses:

Description

Follow up to #22316/[57545].

On the plugins screen, there should be a help tab added about plugin dependencies.

This potentially could be linked to in admin notices and other scenarios where users are notified that something is not right with their current set of installed plugins.

Attachments (2)

6806.diff​ (1.5 KB ) - added by DorZki 2 years ago.
6806.2.diff​ (1.5 KB ) - added by DorZki 2 years ago.

Download all attachments as: .zip

Change History (24)

#1 @costdev
3 years ago

  • Owner set to costdev
  • Status new → assigned

#2 @swissspidy
3 years ago

Just checking in here since there hasn't been any progress here and we're approaching the RC phase. Do you think this is required and still feasible for 6.5? Any help needed?

#3 @swissspidy
3 years ago

  • Keywords needs-patch added

#4 @adarshposimyth
3 years ago

  • Keywords has-patch added; needs-patch removed

@swissspidy , I have added a patch. Kindly check if it can make it to 6.5 RC1

#5 @swissspidy
3 years ago

  • Keywords needs-patch added; has-patch removed

@adarshposimyth I don't see any patch or pull request.

#6 @audrasjb
3 years ago

@adarshposimyth could you please quickly add your patch in the ticket so we can see if it can be quickly committed before RC1 or not? Otherwise I'll punt it to milestone 6.6 at the top of the hour since we'll reach the commit freeze hour :)

#7 @adarshposimyth
3 years ago

@audrasjb my PR isn't ready, will have to punt it to 6.6.

#8 @audrasjb
3 years ago

  • Milestone 6.5 → 6.6

Ok thanks, moving to 6.6.

#9 @NekoJonez
2 years ago

Now, basically this well be a new help option in the help tab... But where do we place it? Do we place it in the plugin section? In the install section AND/OR the plugin overview list?

#10 @oglekler
2 years ago

  • Milestone 6.6 → 6.7
  • Type defect (bug) → enhancement

Sorry, but this is an enhancement, so, I am moving it to the next milestone 😐
@costdev I am ready to collaborate on this if needed 🙂

#11 @DorZki
2 years ago

I've started working on this issue as a part of WCEU Contributor Day.

This ticket was mentioned in ​PR #6806 on ​WordPress/wordpress-develop by ​DorZuberi.


2 years ago
#12

  • Keywords has-patch added; needs-patch removed

@DorZki
2 years ago

#13 @oglekler
2 years ago

  • Keywords needs-copy-review added

@DorZki
2 years ago

This ticket was mentioned in ​Slack in #core-test by audrasjb. ​View the logs.


2 years ago

#15 follow-up: @Boniu91
2 years ago

In general looks good to me. This line needs attention from my point of view:
In case plugin activation link is disabled, this is due to missing required dependencies for the said plugin.
Shouldn't it be:
plugin's
and here:
this is due to missing required dependencies for the said plugin.
Maybe it would be better to change the said to:
related or specific or mentioned

I'm not the native, so definitely experienced eyes are needed.

This ticket was mentioned in ​Slack in #core by dorzki. ​View the logs.


2 years ago

#17 in reply to: ↑ 15 @DorZki
2 years ago

Replying to Boniu91:

In general looks good to me. This line needs attention from my point of view:
In case plugin activation link is disabled, this is due to missing required dependencies for the said plugin.
Shouldn't it be:
plugin's
and here:
this is due to missing required dependencies for the said plugin.
Maybe it would be better to change the said to:
related or specific or mentioned

I'm not the native, so definitely experienced eyes are needed.

Thanks for the feedback, I wish someone would proof-read it and give me final copy so I can update my PR ;)

This ticket was mentioned in ​Slack in #core-test by ankit-k-gupta. ​View the logs.


2 years ago

#19 @Ankit K Gupta
2 years ago

This ticket is assigned to WP 6.7, and we have approximately two weeks until the Beta 1 release. Any progress on this ticket would be greatly appreciated!

#20 @sigurdwatt
2 years ago

Had a look at the PR and I have added some suggested changes for the text, let me know what you think !

Last edited 2 years ago by sigurdwatt (previous) (diff)

#21 @audrasjb
2 years ago

  • Resolution → fixed
  • Status assigned → closed

In 59094:

Help/About: Add plugin dependencies help tab on Plugins screen.

This changeset adds a help tab added about plugin dependencies on the Plugins screen.

Follow-up to [57545].

Fixes #60466.
See #22316.
Props desrosj, swissspidy, adarshposimyth, audrasjb, NekoJonez, DorZki, Boniu91, Ankit-K-Gupta, sigurdwatt.

​@audrasjb commented on ​PR #6806:


2 years ago
#22

Thanks everyone! Committed in https://core.trac.wordpress.org/changeset/59094

Note: See TracTickets for help on using tickets.