Make WordPress Core

Opened 6 months ago

Closed 5 months ago

#60467 closed defect (bug) (fixed)

Improvements to inline note about missing dependencies

Reported by: desrosj's profile desrosj Owned by: costdev's profile costdev
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch 2nd-opinion close
Focuses: Cc:

Description

On the plugins screen, a note is displayed inline when there are dependencies for that plugin missing.

Note: this plugin cannot be activated until the plugins that are required by it are activated.

This sentence should be clarified. Here are some suggestions:

  • This plugin has unmet requirements.
  • This plugin requires the others listed above to be active.
  • The plugins listed above must be active in order to use this plugin.

I also wonder if this note is even needed. If #60466 is implemented, perhaps there could be a "learn more" link next to the dependency list that opens and focuses the help tab. We'd need to check on a11y impacts of this if that's a chosen route.

Another alternative I considered is changing the greyed out, disabled "Activate" text link to something else.

  • Unmet requirements
  • Missing requirements
  • Missing conditions

Change History (9)

#1 @desrosj
6 months ago

Also, if Note: is kept, I wonder if we should add a <strong> tag wrapper. I'm unsure of how this affects a11y, though.

For consistency, see #50785, #56027.

#2 @costdev
5 months ago

  • Owner set to costdev
  • Status changed from new to assigned

#3 @swissspidy
5 months ago

Just checking in here since there hasn't been any progress here and we're approaching the RC phase. Do you think this is required and still feasible for 6.5? Any help needed?

#4 @swissspidy
5 months ago

  • Keywords needs-patch added

This ticket was mentioned in PR #6217 on WordPress/wordpress-develop by @adarshposimyth.


5 months ago
#5

  • Keywords has-patch added; needs-patch removed

Changed greyed out button text 'Activate' to 'Missing conditions'.
Changed dependency note text 'The plugins listed above must be active in order to use this plugin' to 'The plugins listed above must be active in order to use this plugin'.

Trac Ticket : https://core.trac.wordpress.org/ticket/60467

#6 @adarshposimyth
5 months ago

@swissspidy I have added a patch. Kindly check if it can make it to 6.5 RC1. by mistake I had commented on some other ticket.

#7 @costdev
5 months ago

  • Keywords 2nd-opinion added

@desrosj @swissspidy With PR 6070 for #60465 changing this note to a notice when applicable, I'm not sure this ticket is needed anymore. Even with a greyed-out "Activate" action (noting that disabled buttons often use the same string as if they were enabled), it seems like the notice will provide an explanation that's prominent enough for the user to see and take action.

Thoughts?

#8 @costdev
5 months ago

  • Keywords close added

This should be resolved by [57769]. Tentatively adding close ahead of RC1 today as I don't believe there's any remaining work that needs to be done.

#9 @audrasjb
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Looks like this issue has been fixed in [57769].
Closing as fixed for now. Feel free to reopen it if needed.

Note: See TracTickets for help on using tickets.