WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 21 months ago

#60479 closed defect (bug) (fixed)

Remove adminbar skiplink focus fix

Reported by: joedolson's profile joedolson Owned by: joedolson's profile joedolson
Milestone: 6.6 Priority: normal
Severity: normal Version: 3.5
Component: Toolbar Keywords: has-patch commit
Focuses: accessibility, javascript Cc:

Description

The webkit-only skip link target fix for the adminbar is no longer required. The equivalent fix has already been removed from core themes (in #54421), and we should also remove it from the Admin bar. Was added in r22249.

Attachments (2)

60479.diff​ (1.3 KB) - added by joedolson 2 years ago.
60479.patch​ (1.2 KB) - added by shailu25 21 months ago.
Patch Refresh

Download all attachments as: .zip

Change History (11)

#1 @joedolson
2 years ago

  • Owner set to joedolson
  • Status changed from new to assigned

@joedolson
2 years ago

#2 @joedolson
2 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
2 years ago

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
22 months ago

#5 @joedolson
22 months ago

  • Keywords needs-testing added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 6.6

#6 @sabernhardt
22 months ago

  • Keywords needs-refresh added

The patch apparently needs a refresh after [57987] corrected the "Toogle" typo in the next section.

@shailu25
21 months ago

Patch Refresh

#7 @shailu25
21 months ago

  • Keywords needs-refresh removed

#8 @joedolson
21 months ago

  • Keywords commit added; needs-testing removed

Tested. If you use a browser that still requires this change, it no longer works. This is the expected result, but it is also a very rare scenario.

#9 @joedolson
21 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58133:

Toolbar: Accessibility: Remove adminbar skiplink focus fix.

Based on the current browser support policies and expectations, this is no longer needed. There are almost no browsers in use where this is still in use. The same fix was removed from core themes in #54421.

Props joedolson, sabernhardt, shailu25.
Fixes #60479.

Note: See TracTickets for help on using tickets.