WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#60497 closed defect (bug) (fixed)

Typo found in class-ftp.php: replace "resore" with "restore"

Reported by: benniledl Owned by: costdev
Priority: normal Milestone: 6.5
Component: Filesystem API Version: 2.5
Severity: normal Keywords: good-first-bug
Cc: Focuses:

Description

There is a typo "resore" -> "restore"
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-ftp.php#L486

Slack conversation at: ​https://wordpress.slack.com/archives/C02RQBWTW/p1704890892569609

Change History (13)

This ticket was mentioned in ​Slack in #core by benniledl. ​View the logs.
3 years ago

#2 @audrasjb
3 years ago

  • Summary Typo → Typo found in class-ftp.php: replace "resore" with "restore"

#3 @audrasjb
3 years ago

  • Keywords needs-patch good-first-bug added

Thanks for spotting this!

Marking this as a good-first-bug for new contributors.

#4 @costdev
3 years ago

  • Milestone Awaiting Review → 6.5
  • Version → 2.5

Thanks for creating the ticket @benniledl!

Will you be submitting a patch for this also?

#5 @benniledl
3 years ago

I'll be submitting a pr :)

This ticket was mentioned in ​PR #6084 on ​WordPress/wordpress-develop by ​@benniledl.
3 years ago #6

  • Keywords has-patch added; needs-patch removed

Fix a typo in class-ftp-php

Trac ticket: https://core.trac.wordpress.org/ticket/60497

​@benniledl commented on ​PR #6084:
3 years ago #7

Sorry I messed up with the commits again :D

This ticket was mentioned in ​PR #6085 on ​WordPress/wordpress-develop by ​@benniledl.
3 years ago #8

Fix a typo resore to restore

Trac ticket: https://core.trac.wordpress.org/ticket/60497

#9 @benniledl
3 years ago

  • Keywords needs-patch added; has-patch removed

I messed up the first pull request, I have now submitted a new correct pr

#10 @benniledl
3 years ago

  • Keywords needs-patch removed

#11 @costdev
3 years ago

  • Owner set to costdev
  • Status new → reviewing

#12 @costdev
3 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 57591:

Filesystem API: Fix typo in ftp_base::restore().

The ftp_base::restore() method contained a typo internally: "resore" should be "restore".

Follow-up to [7126].

Props benniledl, hellofromTonya, audrasjb.
Fixes #60497.

​@costdev commented on ​PR #6085:
3 years ago #13

Thanks for the PR! Committed in r57591.

Note: See TracTickets for help on using tickets.